Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to update Agentless CloudFormation and Terraform versions #26353

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Document how to update Agentless CloudFormation and Terraform versions #26353

merged 5 commits into from
Nov 22, 2024

Conversation

kacembouhmadi
Copy link
Contributor

What does this PR do? What is the motivation?

Document how to update the Agentless:

  • CloudFormation template version
  • Terraform modules version

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@kacembouhmadi kacembouhmadi force-pushed the kacem.bouhmadi/agentless-template-update branch 2 times, most recently from affed1d to 5c65c74 Compare November 19, 2024 12:59
@kacembouhmadi kacembouhmadi marked this pull request as ready for review November 19, 2024 13:00
@kacembouhmadi kacembouhmadi requested a review from a team as a code owner November 19, 2024 13:00
@kacembouhmadi kacembouhmadi force-pushed the kacem.bouhmadi/agentless-template-update branch from 5c65c74 to 93789e7 Compare November 19, 2024 14:03
janine-c
janine-c reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kacembouhmadi , I made some minor suggestions for readability and structure - let me know if you have any questions or if you'd like me to take another look 🙂

content/en/security/cloud_security_management/setup/agentless_scanning/cloudformation.md Outdated Show resolved Hide resolved
content/en/security/cloud_security_management/setup/agentless_scanning/cloudformation.md Show resolved Hide resolved
content/en/security/cloud_security_management/setup/agentless_scanning/quick_start.md Outdated Show resolved Hide resolved
content/en/security/cloud_security_management/setup/agentless_scanning/quick_start.md Show resolved Hide resolved
janine-c
janine-c reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I made some more suggestions, including some formatting details I missed the first time around.

Just wondering about some specifics about the UI so we can set expectations with users, but we don't have to put too much time into this - the point isn't to exhaustively document the AWS UI, just to help people understand where they are in the process. As always, let me know if you have any questions or when you're ready for the final rubber stamp 🙂

content/en/security/cloud_security_management/setup/agentless_scanning/cloudformation.md Outdated Show resolved Hide resolved
content/en/security/cloud_security_management/setup/agentless_scanning/quick_start.md Outdated Show resolved Hide resolved
@kacembouhmadi @janine-c
Improve CFN doc
17606bf 
Co-authored-by: Janine Chan <[email protected]>
@kacembouhmadi
Copy link
Contributor Author

Looking good! I made some more suggestions, including some formatting details I missed the first time around.

Just wondering about some specifics about the UI so we can set expectations with users, but we don't have to put too much time into this - the point isn't to exhaustively document the AWS UI, just to help people understand where they are in the process. As always, let me know if you have any questions or when you're ready for the final rubber stamp 🙂

Thanks Janine

@kacembouhmadi
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 22, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-22 08:50:04 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-22 12:50:07 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

janine-c
janine-c approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thanks Kacem!

@janine-c
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 22, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-22 15:32:58 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 11m.

@dd-mergequeue dd-mergequeue bot merged commit 3ff5d8a into master Nov 22, 2024
23 of 26 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kacem.bouhmadi/agentless-template-update branch November 22, 2024 15:40
theraffoul pushed a commit that referenced this pull request Nov 25, 2024
@kacembouhmadi @k3nz0
@janine-c @theraffoul
Document how to update Agentless CloudFormation and Terraform versions (
dfe4588 
#26353)

* Document how to update Agentless cloudformation and terraform versions

* Apply suggestions from code review

Co-authored-by: Moez Ezzeddine <[email protected]>

* Apply suggestions from code review

Co-authored-by: Moez Ezzeddine <[email protected]>

* Improve the CloudFormation documentation

* Improve CFN doc

Co-authored-by: Janine Chan <[email protected]>

---------

Co-authored-by: Moez Ezzeddine <[email protected]>
Co-authored-by: Janine Chan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k3nz0 k3nz0 k3nz0 left review comments

@janine-c janine-c janine-c approved these changes

@jvanbrie jvanbrie jvanbrie approved these changes

@diogocp diogocp diogocp approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kacembouhmadi @janine-c @k3nz0 @diogocp @jvanbrie