[DOCS-9537] Add manual steps for nginx browser RUM #26323

rtrieu · 2024-11-15T20:29:47Z

What does this PR do? What is the motivation?

Adds steps for how to manually instrument RUM for nginx web servers

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Needs PM/eng review before merging.

github-actions · 2024-11-15T20:33:36Z

Preview links (active after the `build_preview` check completes)

Modified Files

https://docs-staging.datadoghq.com/rtrieu/docs-9537-manual-steps-nginx/real_user_monitoring/browser/setup/server

hestonhoffman

Really just the one edit to capitalize NGINX. I don't know if I was able to get to all of them. You might want to do a quick pass once you've applied these.

content/en/real_user_monitoring/browser/setup/server.md

Co-authored-by: Heston Hoffman <[email protected]>

hestonhoffman

One more small edit

content/en/real_user_monitoring/browser/setup/server.md

Co-authored-by: Heston Hoffman <[email protected]>

rtrieu · 2024-11-18T21:40:38Z

/merge

dd-devflow · 2024-11-18T21:40:49Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-18 21:40:49 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 30m.

2024-11-18 21:44:49 UTC ⚠️ MergeQueue: This merge request build was cancelled

This merge request build was cancelled

rtrieu · 2024-11-18T21:44:40Z

/merge -c

content/en/real_user_monitoring/browser/setup/server.md

dmehala

Few comments there and there. It's getting increasingly confusing from the customer POV. The title mentions "RUM Browser Monitoring Server-Side (Auto) Instrumentation", some part of the doc says "Auto-instrumentation" and "Manual-instrumentation".

We committed to call the solution "Auto-Instrumentation". It worth to revisit the doc with the definitive naming.

Co-authored-by: Benoît <[email protected]> Co-authored-by: Damien Mehala <[email protected]>

rtrieu · 2024-11-20T21:44:53Z

/merge

dd-devflow · 2024-11-20T21:45:05Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-20 21:45:04 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 16m.

* update sentence * moved limitations add reference * add rest of links * fix links * fix all links * another header * fix links * Apply suggestions from code review Co-authored-by: Heston Hoffman <[email protected]> * remaining capitalization * Update content/en/real_user_monitoring/browser/setup/server.md Co-authored-by: Heston Hoffman <[email protected]> * Apply suggestions from code review Co-authored-by: Benoît <[email protected]> Co-authored-by: Damien Mehala <[email protected]> * update limitation based on fb * more detailed fixes --------- Co-authored-by: Heston Hoffman <[email protected]> Co-authored-by: Benoît <[email protected]> Co-authored-by: Damien Mehala <[email protected]>

rtrieu added 5 commits November 15, 2024 09:43

update sentence

e0d0c22

moved limitations add reference

5e6373a

add rest of links

73ee407

fix links

def8f99

fix all links

cdf3001

rtrieu requested review from a team as code owners November 15, 2024 20:29

rtrieu added 2 commits November 15, 2024 12:40

another header

e184ad2

fix links

c6a99f5

hestonhoffman reviewed Nov 18, 2024

View reviewed changes

rtrieu and others added 2 commits November 18, 2024 12:17

Apply suggestions from code review

d429ccb

Co-authored-by: Heston Hoffman <[email protected]>

remaining capitalization

7aac2b4

rtrieu requested review from hestonhoffman, dmehala and sarjyusuf November 18, 2024 20:30

hestonhoffman reviewed Nov 18, 2024

View reviewed changes

content/en/real_user_monitoring/browser/setup/server.md Outdated Show resolved Hide resolved

Update content/en/real_user_monitoring/browser/setup/server.md

157daca

Co-authored-by: Heston Hoffman <[email protected]>

rtrieu requested a review from hestonhoffman November 18, 2024 21:24

hestonhoffman approved these changes Nov 18, 2024

View reviewed changes

dd-devflow bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Nov 18, 2024

dd-devflow bot added mergequeue-status: removed and removed mergequeue-status: in_progress labels Nov 18, 2024

BenoitZugmeyer reviewed Nov 19, 2024

View reviewed changes

dmehala reviewed Nov 19, 2024

View reviewed changes

content/en/real_user_monitoring/browser/setup/server.md Outdated Show resolved Hide resolved

dmehala reviewed Nov 19, 2024

View reviewed changes

content/en/real_user_monitoring/browser/setup/server.md Outdated Show resolved Hide resolved

dmehala reviewed Nov 19, 2024

View reviewed changes

content/en/real_user_monitoring/browser/setup/server.md Outdated Show resolved Hide resolved

dmehala reviewed Nov 19, 2024

View reviewed changes

rtrieu and others added 2 commits November 19, 2024 07:17

Apply suggestions from code review

fe332ec

Co-authored-by: Benoît <[email protected]> Co-authored-by: Damien Mehala <[email protected]>

update limitation based on fb

891e469

rtrieu requested review from BenoitZugmeyer and dmehala November 20, 2024 15:42

more detailed fixes

94c9a96

dd-devflow bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: removed mergequeue-status: queued labels Nov 20, 2024

dd-mergequeue bot merged commit b6de77a into master Nov 20, 2024
15 of 19 checks passed

dd-mergequeue bot deleted the rtrieu/docs-9537-manual-steps-nginx branch November 20, 2024 21:55

dd-devflow bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Nov 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DOCS-9537] Add manual steps for nginx browser RUM #26323

[DOCS-9537] Add manual steps for nginx browser RUM #26323

rtrieu commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

hestonhoffman left a comment

hestonhoffman left a comment

rtrieu commented Nov 18, 2024

dd-devflow bot commented Nov 18, 2024 •

edited

Loading

rtrieu commented Nov 18, 2024

dmehala left a comment

rtrieu commented Nov 20, 2024

dd-devflow bot commented Nov 20, 2024 •

edited

Loading

[DOCS-9537] Add manual steps for nginx browser RUM #26323

[DOCS-9537] Add manual steps for nginx browser RUM #26323

Conversation

rtrieu commented Nov 15, 2024

What does this PR do? What is the motivation?

Merge instructions

Additional notes

github-actions bot commented Nov 15, 2024

Preview links (active after the build_preview check completes)

Modified Files

hestonhoffman left a comment

Choose a reason for hiding this comment

hestonhoffman left a comment

Choose a reason for hiding this comment

rtrieu commented Nov 18, 2024

dd-devflow bot commented Nov 18, 2024 • edited Loading

Devflow running: /merge

rtrieu commented Nov 18, 2024

dmehala left a comment

Choose a reason for hiding this comment

rtrieu commented Nov 20, 2024

dd-devflow bot commented Nov 20, 2024 • edited Loading

Devflow running: /merge

Preview links (active after the `build_preview` check completes)

dd-devflow bot commented Nov 18, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Nov 20, 2024 •

edited

Loading

Devflow running: `/merge`