Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to monitor deadlocks in DBM #26262

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

na-ji
Copy link
Member

@na-ji na-ji commented Nov 13, 2024

What does this PR do? What is the motivation?

The goal is to document a new feature on the Database Monitoring product. DBM added support for deadlocks events on SQL Server. It requires Agent 7.59+ and some special config to enable.

Additional notes

None.

@na-ji na-ji self-assigned this Nov 13, 2024
@github-actions github-actions bot added the Guide Content impacting a guide label Nov 13, 2024
@na-ji na-ji force-pushed the naji.astier/dbm/add-deadlock-documentation branch from 5abcdc2 to 269dc95 Compare November 13, 2024 14:07
@na-ji na-ji marked this pull request as ready for review November 13, 2024 15:34
@na-ji na-ji requested review from a team as code owners November 13, 2024 15:34
@michaelcretzman
Copy link
Contributor

created an editorial ticket for this (DOCS-9512)

@janine-c janine-c added the editorial review Waiting on a more in-depth review label Nov 13, 2024
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor feedback on the PR.

content/en/database_monitoring/guide/sql_deadlock.md Outdated Show resolved Hide resolved
content/en/database_monitoring/guide/_index.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/rds.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/gcsql.md Outdated Show resolved Hide resolved
content/en/database_monitoring/guide/sql_deadlock.md Outdated Show resolved Hide resolved
content/en/database_monitoring/guide/sql_deadlock.md Outdated Show resolved Hide resolved
content/en/database_monitoring/guide/sql_deadlock.md Outdated Show resolved Hide resolved
content/en/database_monitoring/guide/sql_deadlock.md Outdated Show resolved Hide resolved
content/en/database_monitoring/guide/sql_deadlock.md Outdated Show resolved Hide resolved
@na-ji na-ji requested a review from drichards-87 November 19, 2024 13:29
@na-ji na-ji force-pushed the naji.astier/dbm/add-deadlock-documentation branch from bbe7c00 to b743c9a Compare November 19, 2024 15:00
@na-ji na-ji requested a review from drichards-87 November 21, 2024 17:56
@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 21, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-21 17:58:36 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-21 18:13:52 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 12m.

@dd-mergequeue dd-mergequeue bot merged commit 4f9f9a3 into master Nov 21, 2024
21 of 24 checks passed
@dd-mergequeue dd-mergequeue bot deleted the naji.astier/dbm/add-deadlock-documentation branch November 21, 2024 18:22
theraffoul pushed a commit that referenced this pull request Nov 25, 2024
* Document how to monitor deadlocks in DBM

* Reword a few things and remove the Notes section

* Fix broken link on deadlock XE buffer

* Add more information on what to expect from the deadlock tab

* Fix tense in guide title

* Fix grammar and punctuation on exploring deadlock events section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants