Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-9306] Synthetics browser tests: extract multiple variables #25952

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

aliciascott
Copy link
Contributor

@aliciascott aliciascott commented Oct 28, 2024

What does this PR do? What is the motivation?

New feature: DOCS-9306

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@aliciascott aliciascott requested a review from a team as a code owner October 28, 2024 21:00
@github-actions github-actions bot added the Images Images are added/removed with this PR label Oct 28, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion

content/en/synthetics/browser_tests/actions.md Outdated Show resolved Hide resolved
@aliciascott
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 28, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Oct 28, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 25m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 6d3bb8d into master Oct 28, 2024
24 of 26 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aliciascott/DOCS-9306-extract-variables branch October 28, 2024 22:53
theraffoul pushed a commit that referenced this pull request Nov 25, 2024
)

* extract multiple variables

* Update content/en/synthetics/browser_tests/actions.md

Co-authored-by: Heston Hoffman <[email protected]>

---------

Co-authored-by: Heston Hoffman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants