Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add job update step if PR approved #25841

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Add job update step if PR approved #25841

merged 3 commits into from
Oct 21, 2024

Conversation

devindford
Copy link
Contributor

@devindford devindford commented Oct 21, 2024 •
edited
Loading

What does this PR do? What is the motivation?

  • Update the workflow to only run once a PR is reviewed. Since we require at least 1 reviewer to merge, the PR will be blocked until a review is completed, then the workflow will trigger and check to ensure that required codeowners have approved the PR. If they have the job will pass

Merge instructions

  • Please merge after reviewing

Additional notes

@devindford devindford requested a review from a team as a code owner October 21, 2024 20:41
@github-actions github-actions bot added the Github Related to Github configurations label Oct 21, 2024
hestonhoffman
hestonhoffman previously approved these changes Oct 21, 2024
View reviewed changes
bgdeutsch
bgdeutsch previously approved these changes Oct 21, 2024
View reviewed changes
@devindford devindford dismissed stale reviews from bgdeutsch and hestonhoffman October 21, 2024 20:58

test

bgdeutsch
bgdeutsch previously approved these changes Oct 21, 2024
View reviewed changes
@devindford devindford changed the title Add job update ste if PR approved Add job update step if PR approved Oct 21, 2024
@devindford
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 21, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 26m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 68b97da into master Oct 21, 2024
19 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the devin.ford/workflow-trigger-fix branch October 21, 2024 23:21
theraffoul pushed a commit that referenced this pull request Nov 25, 2024
@devindford @theraffoul
Add job update step if PR approved (#25841)
8e02e8a 
* fix: add job update if approved

* chore: update triggers ro only run on review

* feat: add check to ensure we're on the master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hestonhoffman hestonhoffman hestonhoffman approved these changes

@bgdeutsch bgdeutsch bgdeutsch approved these changes

Assignees
No one assigned
Labels
Github Related to Github configurations mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devindford @bgdeutsch @hestonhoffman