Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test visibility] Update "new test" logic for early flake detection #25769

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

juan-fernandez
Copy link
Contributor

@juan-fernandez juan-fernandez commented Oct 17, 2024

What does this PR do? What is the motivation?

The "new test" logic has changed in our backend. We need to reflect this in the docs. I've removed the explanation image until we update it, because that's not the logic anymore.

Merge instructions

  • Please merge after reviewing

Additional notes

https://docs-staging.datadoghq.com/juan-fernandez/update-efd-logic/tests/early_flake_detection/?tab=javascripttypescript

@github-actions github-actions bot added the Images Images are added/removed with this PR label Oct 17, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@juan-fernandez juan-fernandez marked this pull request as ready for review October 17, 2024 10:28
@juan-fernandez juan-fernandez requested review from a team as code owners October 17, 2024 10:28
@juan-fernandez juan-fernandez added the Do Not Merge Just do not merge this PR :) label Oct 17, 2024
@juan-fernandez juan-fernandez removed the Do Not Merge Just do not merge this PR :) label Oct 18, 2024
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @juan-fernandez just a couple small things on this one and also can you add back the image itself? It's ok to remove that img tag in the markdown but just physically leave the image in the repo as it will take a few days to update on the non-English docs and we don't want it to display as a broken image in the meantime, thanks!

content/en/tests/early_flake_detection/_index.md Outdated Show resolved Hide resolved
content/en/tests/early_flake_detection/_index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Images Images are added/removed with this PR label Oct 18, 2024
@juan-fernandez
Copy link
Contributor Author

Hi @juan-fernandez just a couple small things on this one and also can you add back the image itself? It's ok to remove that img tag in the markdown but just physically leave the image in the repo as it will take a few days to update on the non-English docs and we don't want it to display as a broken image in the meantime, thanks!

that makes sense, thanks. I added it back

Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you looks great!

@aliciascott
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 18, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 26m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 9307756 into master Oct 18, 2024
21 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the juan-fernandez/update-efd-logic branch October 18, 2024 16:18
theraffoul pushed a commit that referenced this pull request Nov 25, 2024
…25769)

* new logic

* Apply suggestions from code review

Co-authored-by: Alicia Scott <[email protected]>

* add back image

---------

Co-authored-by: Alicia Scott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants