-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test visibility] Update "new test" logic for early flake detection #25769
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @juan-fernandez just a couple small things on this one and also can you add back the image itself? It's ok to remove that img
tag in the markdown but just physically leave the image in the repo as it will take a few days to update on the non-English docs and we don't want it to display as a broken image in the meantime, thanks!
Co-authored-by: Alicia Scott <[email protected]>
that makes sense, thanks. I added it back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you looks great!
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
…25769) * new logic * Apply suggestions from code review Co-authored-by: Alicia Scott <[email protected]> * add back image --------- Co-authored-by: Alicia Scott <[email protected]>
What does this PR do? What is the motivation?
The "new test" logic has changed in our backend. We need to reflect this in the docs. I've removed the explanation image until we update it, because that's not the logic anymore.
Merge instructions
Additional notes
https://docs-staging.datadoghq.com/juan-fernandez/update-efd-logic/tests/early_flake_detection/?tab=javascripttypescript