Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wildcard widget #25671
Add Wildcard widget #25671
Changes from 2 commits
fbe3f6b
2b6ecb0
88f9819
9585642
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't immediately clear to me what this JSON represents - and the highlighted values are
env
andexample
, so I wasn't sure wherequery1
came in. I think you could probably add a little more signposting around these examples to explain what you're showing the user. Is the point that the visualization starts out broken and then you fix it by reassigning the alias? If this is the case, it's useful to let the user know you're going to show them a broken example before the example appears.Sidenote: I like the use of tables here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy paste error 😞 This should be
query1
. I agree this could be broken down more. I added a new section specifically to map values between Datadog and Vega-Lite, hopefully that makes it clearer!