Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baggage Initial Documentation #25644

Closed
wants to merge 12 commits into from
Closed

Baggage Initial Documentation #25644

wants to merge 12 commits into from
+16 −1

Conversation

tushar-datadog
Copy link
Contributor

@tushar-datadog tushar-datadog commented Oct 8, 2024 •
edited by lucaspimentel
Loading

What does this PR do? What is the motivation?

An initial guide to Baggage API support

Merge instructions

  • Please merge after reviewing

Additional notes

Needs additional pages to be updated

@tushar-datadog tushar-datadog requested a review from a team as a code owner October 8, 2024 18:37
buraizu
buraizu requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting a couple of minor updates. Also, could you please confirm if this is ready to merge once the updates are applied?

content/en/tracing/glossary/_index.md Outdated Show resolved Hide resolved
content/en/tracing/glossary/_index.md Outdated Show resolved Hide resolved
bm1549
bm1549 approved these changes Oct 9, 2024
View reviewed changes
content/en/tracing/glossary/_index.md Outdated Show resolved Hide resolved
content/en/tracing/glossary/_index.md Outdated Show resolved Hide resolved
buraizu
buraizu requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up, just a few additional edits

content/en/tracing/trace_collection/trace_context_propagation/_index.md Outdated Show resolved Hide resolved
content/en/tracing/glossary/_index.md Outdated Show resolved Hide resolved
content/en/tracing/trace_collection/trace_context_propagation/_index.md Outdated Show resolved Hide resolved
content/en/tracing/trace_collection/trace_context_propagation/_index.md Outdated Show resolved Hide resolved
content/en/tracing/trace_collection/trace_context_propagation/_index.md Outdated Show resolved Hide resolved
@lucaspimentel lucaspimentel mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraizu buraizu buraizu approved these changes

@bm1549 bm1549 bm1549 approved these changes

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tushar-datadog @lucaspimentel @bm1549 @buraizu