Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for ddtags in OTel logs #24500

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Add docs for ddtags in OTel logs #24500

merged 2 commits into from
Aug 7, 2024

Conversation

liustanley
Copy link
Contributor

What does this PR do? What is the motivation?

Add docs for adding custom tags to OTel logs through the ddtags attribute. Corresponding collector docs: open-telemetry/opentelemetry-collector-contrib#34439

Merge instructions

  • Please merge after reviewing

Additional notes

@liustanley liustanley requested a review from a team as a code owner August 6, 2024 20:31
@liustanley liustanley requested review from mx-psi and songy23 August 6, 2024 20:34
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Preview links (active after the build_preview check completes)

Modified Files

log_statements:
- context: log
statements:
- set(attributes["ddtags"], "first_custom:tag, second_custom:tag")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure that this is correct and that each custom tag shouldn't be in its own set of quotation marks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes those are comma-separated

@liustanley liustanley requested a review from neko-dd August 7, 2024 14:41
@neko-dd neko-dd merged commit 96b0ff0 into master Aug 7, 2024
19 checks passed
@neko-dd neko-dd deleted the stanley.liu/ddtags branch August 7, 2024 16:37
rtrieu pushed a commit that referenced this pull request Sep 3, 2024
* Add docs for ddtags

* Fix yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants