-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeowner workflow check #24496
Add codeowner workflow check #24496
Conversation
Code Owners Approval Status✅ @DataDog/WebOps-Platform ✅ All required code owners have approved this pull request. |
abf34f7
to
ddde691
Compare
So discussing this further we determined there are certain cases where a pr will have 2 or more codeowners where we don’t want to enforce all owners to approve. This is when a dev team are listed as code owners over parts of the docs but docs team should be able to approve/merge without their consent as they are ultimately the owners of the content. @devindford Can we scope this work to enforce only when our teams are involved? |
@davidejones After some further discussion with docs, for now they want to trial it the current way and attempt to get all approvals. If this becomes a pain point they will reach out and I will update it to only require Docs (and websites where appropriate) to pass |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
* feat: create new workflow, squash commits * chore: remove PR comment section of workflow
What does this PR do? What is the motivation?
CODEOWNER
file reviewersPassing job after last required approval https://github.com/DataDog/documentation/actions/runs/10292292875/job/28486392695
Failed check on only one approval https://github.com/DataDog/documentation/actions/runs/10292033909
Merge instructions
Additional notes
This is an after action item as part of incident web-incident-30 in an effort to ensure the teams that have some type of ownership over files are aware of changes and can review them before they are merged to production
I squashed locally since there was far too many "chore: debug" commits 🙄 so that is why there is a force push
Note from 08/15/24
The codeowner file was restructured on master and then pulled into this branch, the job outputs listed in the links shows how it worked when there was dual codeowners on the update being made originally, but now only shows the platform approval since we removed Docs from as codeowners on the
CODEOWNERS
file