Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-8434] explaining tagging on network analytics #24458

Merged
merged 9 commits into from
Aug 21, 2024
Merged

[DOCS-8434] explaining tagging on network analytics #24458

merged 9 commits into from
Aug 21, 2024

Conversation

aliciascott
Copy link
Contributor

@aliciascott aliciascott commented Aug 2, 2024 •
edited
Loading

What does this PR do? What is the motivation?

This PR adds a new diagram to explain how NPM works when filtered by tags, more search examples and screenshots.

Merge instructions

Do not merge - waiting on final PM approval

  • Please merge after reviewing

Additional notes

@aliciascott aliciascott requested a review from a team as a code owner August 2, 2024 22:50
@aliciascott aliciascott added the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 2, 2024
@github-actions github-actions bot added the Images Images are added/removed with this PR label Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Preview links (active after the build_preview check completes)

Modified Files

@aliciascott aliciascott removed the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 21, 2024
jhgilbert
jhgilbert approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions, thank you!

content/en/network_monitoring/performance/network_analytics.md Outdated Show resolved Hide resolved
content/en/network_monitoring/performance/network_analytics.md Outdated Show resolved Hide resolved
@aliciascott aliciascott merged commit b27eaa2 into master Aug 21, 2024
14 checks passed
@aliciascott aliciascott deleted the aliciascott/DOCS-8434-NPM-updates branch August 21, 2024 22:47
rtrieu pushed a commit that referenced this pull request Sep 3, 2024
@aliciascott @jhgilbert @rtrieu
[DOCS-8434] explaining tagging on network analytics (#24458)
aeae1cd 
* explaining tagging on network analytics

* updating main screenshot

* updating Network analytics - removing table

* small fix

* adding different screenshot for filtering

* Apply suggestions from code review

Co-authored-by: Jen Gilbert <[email protected]>

---------

Co-authored-by: Jen Gilbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhgilbert jhgilbert jhgilbert approved these changes

Assignees
No one assigned
Labels
Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliciascott @jhgilbert