Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUDCRAFT-354] Version History #24367

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

jamesponddotco
Copy link
Contributor

What does this PR do? What is the motivation?

Adds documentation about the Version History feature inside Cloudcraft.

Merge instructions

Please wait until the Cloudcraft team has reviewed the content before going ahead with the review and merging of the PR.

  • Please merge after reviewing

@jamesponddotco jamesponddotco requested a review from a team July 29, 2024 15:45
@jamesponddotco jamesponddotco requested a review from a team as a code owner July 29, 2024 15:45
@github-actions github-actions bot added the Images Images are added/removed with this PR label Jul 29, 2024
Copy link
Contributor

Copy link

@srividya-rajagopalan srividya-rajagopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I have requested @licaroline to review as well.

@drichards-87
Copy link
Contributor

Created DOCS-8583 for Docs Team review.

@drichards-87 drichards-87 added the editorial review Waiting on a more in-depth review label Jul 29, 2024
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jamesponddotco this looks great, just a couple small edits, let me know once you've committed in those fixes and I'll merge the PR !

content/en/cloudcraft/getting-started/version-history.md Outdated Show resolved Hide resolved
content/en/cloudcraft/getting-started/version-history.md Outdated Show resolved Hide resolved
content/en/cloudcraft/getting-started/version-history.md Outdated Show resolved Hide resolved
@aliciascott
Copy link
Contributor

Hi @jamesponddotco looks like this got a little stale, just checking in to see if you needed any help making the suggested updates? After those are fixed we can go ahead and merge :)

@aliciascott aliciascott merged commit ce3eea2 into master Aug 21, 2024
14 checks passed
@aliciascott aliciascott deleted the james.pond/cc-version-history branch August 21, 2024 22:19
rtrieu pushed a commit that referenced this pull request Sep 3, 2024
* Document the version history feature

Signed-off-by: James Pond <[email protected]>

* Add article to the index

Signed-off-by: James Pond <[email protected]>

* Add article images

Signed-off-by: James Pond <[email protected]>

* Apply suggestions from code review

---------

Signed-off-by: James Pond <[email protected]>
Co-authored-by: Alicia Scott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants