Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-5565] Add iframe support explanation #24299

Merged
merged 10 commits into from
Jul 30, 2024
Merged

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Jul 24, 2024

What does this PR do? What is the motivation?

Add public documentation about seeing iframes in session replay

Merge instructions

  • Please merge after reviewing

Additional notes

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Preview links (active after the build_preview check completes)

Modified Files

@cy-moi cy-moi marked this pull request as ready for review July 26, 2024 07:27
@cy-moi cy-moi requested review from a team as code owners July 26, 2024 07:27
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion.

@cy-moi cy-moi requested review from a team as code owners July 29, 2024 11:25
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR Guide Content impacting a guide labels Jul 29, 2024
@cy-moi cy-moi force-pushed the congyao/RUM-5565-doc-on-iframe branch from 48c88c2 to 2c93b9a Compare July 29, 2024 11:26
@github-actions github-actions bot removed Architecture Everything related to the Doc backend Images Images are added/removed with this PR Guide Content impacting a guide labels Jul 29, 2024
@cy-moi cy-moi removed the request for review from a team July 29, 2024 11:27
@cy-moi cy-moi removed request for a team, rodrimendoza and ManuelPalenzuelaDD July 29, 2024 11:27
@neko-dd neko-dd merged commit bdebb66 into master Jul 30, 2024
14 checks passed
@neko-dd neko-dd deleted the congyao/RUM-5565-doc-on-iframe branch July 30, 2024 16:46
rtrieu pushed a commit that referenced this pull request Sep 3, 2024
* Add iframe support explanation

* Avoid temporal wordings

* Remove extra white space

* Fix wording

* Remove unnecessary mentions

* Fix wording

* Fix wording

* Update content/en/real_user_monitoring/session_replay/browser/troubleshooting.md

Co-authored-by: Michael Cretzman <[email protected]>

* Do not capitalize iframe

---------

Co-authored-by: Michael Cretzman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants