Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image to shortcode #23098

Merged
merged 5 commits into from
May 10, 2024
Merged

Add image to shortcode #23098

merged 5 commits into from
May 10, 2024

Conversation

maycmlee
Copy link
Contributor

@maycmlee maycmlee commented May 9, 2024 •
edited
Loading

What does this PR do? What is the motivation?

  • Move image from the parent page to general reuse shortcode.
  • Add a new processor shortcode for SDS use case.

Merge instructions

  • Please merge after reviewing

Additional notes

@maycmlee maycmlee added the WORK IN PROGRESS No review needed, it's a wip ;) label May 9, 2024
@maycmlee maycmlee requested review from a team as code owners May 9, 2024 19:30
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label May 9, 2024
@github-actions github-actions bot removed the Architecture Everything related to the Doc backend label May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label May 9, 2024
@maycmlee maycmlee removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 10, 2024
aliciascott
aliciascott approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Noted in slack to re-take images without the mouse cursor :)

@maycmlee maycmlee merged commit 3461c5f into master May 10, 2024
15 checks passed
@maycmlee maycmlee deleted the may/add-image-to-reuse-shortcode branch May 10, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliciascott aliciascott aliciascott approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maycmlee @aliciascott @renteria1010