Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udpdate SLO doc images #23036

Merged
merged 4 commits into from
May 10, 2024
Merged

udpdate SLO doc images #23036

merged 4 commits into from
May 10, 2024

Conversation

roxanne-moslehi
Copy link
Contributor

@roxanne-moslehi roxanne-moslehi commented May 7, 2024 •
edited
Loading

What does this PR do? What is the motivation?

Merge instructions

  • Please merge after reviewing

Additional notes

@roxanne-moslehi roxanne-moslehi requested a review from a team as a code owner May 7, 2024 15:26
@github-actions github-actions bot added the Images Images are added/removed with this PR label May 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

Preview links (active after the build_preview check completes)

Modified Files

@maycmlee
Copy link
Contributor

maycmlee commented May 7, 2024 •
edited by jira bot
Loading

Create DOCS-7900 of docs review.

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review label May 7, 2024
estherk15
estherk15 reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly non blocking feedback, and PII for an image.

static/images/service_management/service_level_objectives/metric_slo_side_panel.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you blur your name?

content/en/service_management/service_level_objectives/monitor.md Outdated Show resolved Hide resolved
content/en/service_management/service_level_objectives/metric.md Outdated Show resolved Hide resolved
content/en/service_management/service_level_objectives/monitor.md Outdated Show resolved Hide resolved
content/en/service_management/service_level_objectives/monitor.md Outdated Show resolved Hide resolved
content/en/service_management/service_level_objectives/monitor.md Outdated Show resolved Hide resolved
@roxanne-moslehi
Copy link
Contributor Author

@estherk15 We can merge this if it looks good!

@estherk15 estherk15 merged commit 503bc15 into master May 10, 2024
14 checks passed
@estherk15 estherk15 deleted the rox/update-images-slos branch May 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 approved these changes

Assignees

@estherk15 estherk15

Labels
editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roxanne-moslehi @maycmlee @estherk15