-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTel Custom Instrumentation Pages #22967
Conversation
…000FF/otel-api-updates
content/en/tracing/trace_collection/custom_instrumentation/dotnet/otel.md
Outdated
Show resolved
Hide resolved
… Java - replace trace annotations sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some suggestions!
content/en/tracing/trace_collection/custom_instrumentation/dotnet/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/dotnet/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/dotnet/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/dotnet/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/nodejs/otel.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Esther Kim <[email protected]>
@estherk15 - Awesome, thank you for the great suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @brett0000FF 👋
Sorry the the change request 😞
They shared me your PR for a quick review as the developer of OTel support the Java tracer, but I think you might need to pair with @bm1549 team to help you fix the code samples: some are to avoid completely, some are not doing what they are for, one might not compile.
It's nothing bad or hard to fix, but just make sure to get them tested (compile and run as expected) before publishing them 🙏 I am part of platform team now but you should be in good hands with @bm1549
|
||
- Datadog Java tracing library `dd-trace-java` version 1.10.0 or greater. | ||
<div class="alert alert-info">OpenTelemetry is supported in Java after version 1.24.0.</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes the decision of dropping 1.10?
1.24 introduces the new span naming and span links only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tushar-datadog - I think you added this change to our draft. Do you have an answer for this? Thanks!
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
}); | ||
} | ||
{{< /highlight >}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page has all the code examples for how to start a span:
https://datadoghq.dev/dd-trace-js/interfaces/export_.opentelemetry.Tracer.html
One important thing to note and mention is that the nodejs tracer doesn't currently support the Otel Context API, so user's should be advised against creating spans from otel contexts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look! We originally had a table describing OTel features that are not supported by each tracer, but that was leading to confusion for those that are unfamiliar with OTel. I'll take a look and see where we could add this info about the Context API. 👍
Co-authored-by: Bruce Bujon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few non blocking comments. Overall this change looks good
content/en/tracing/trace_collection/custom_instrumentation/python/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/python/otel.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
content/en/tracing/trace_collection/custom_instrumentation/php/otel.md
Outdated
Show resolved
Hide resolved
Regarding PHP, the PHP developers I would loop in are not around until Friday. Though, based on our internal docs, the content here looks accurate to me. Let me know how you want to proceed. |
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/java/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/custom_instrumentation/go/otel.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Zach Montoya <[email protected]>
…umentation into brett0000FF/otel-api-updates
What does this PR do? What is the motivation?
Teams to review:
Merge instructions
Additional notes