Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-7747 Add DORA Metrics Data Collected Documentation #22719

Closed
wants to merge 3 commits into from

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented Apr 17, 2024

What does this PR do? What is the motivation?

Removes duplicate information in the product landing page and the Setup page, adds a Data Collected page, and screenshots of the DORA Metrics page.

Merge instructions

  • Please merge after reviewing

Additional notes

Revamps the DORA Metrics product landing page + Setup documentation, adds a Data Collected page.
@alai97 alai97 requested review from a team as code owners April 17, 2024 23:07
@alai97 alai97 requested review from drodriguezhdez and kassenq and removed request for drodriguezhdez April 17, 2024 23:07
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels Apr 17, 2024
@rtrieu
Copy link
Contributor

rtrieu commented Apr 18, 2024

Created DOCS-7751 for editorial review.

@rtrieu rtrieu added the editorial review Waiting on a more in-depth review label Apr 18, 2024
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alai97 looks great, just a few things where some links need fixed, but otherwise approved so it doesn't hold you up. Let me know if you need a re-review :)

[7]: https://docs.datadoghq.com/service_management/events/explorer/
[2]: /dora_metrics/setup/
[3]: /dora_metrics/data_collected/
[4]: https://app.datadoghq.com/ci/dora
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[4]: https://app.datadoghq.com/ci/dora
[4]: https://app.datadoghq.com/ci/dora

This page results in a 404 for me, are certain permissions required ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you in the Demo instance? We should see the Getting Started blank page:

Screenshot 2024-04-24 at 4 20 37 PM

content/en/dora_metrics/_index.md Outdated Show resolved Hide resolved
content/en/dora_metrics/data_collected/_index.md Outdated Show resolved Hide resolved
content/en/dora_metrics/data_collected/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Alicia Scott <[email protected]>
@alai97 alai97 closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants