Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize mobile crash report setup #22713

Merged
merged 14 commits into from
Apr 30, 2024
Merged

Standardize mobile crash report setup #22713

merged 14 commits into from
Apr 30, 2024

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Apr 17, 2024 •
edited
Loading

What does this PR do? What is the motivation?

As per discussion with @MaelNamNam, this standardizes the mobile crash reporting setup pages across all frameworks:

  • All pages now have these sections:
    • Overview
    • Setup
    • Get deobfuscated stack traces
    • Limitations
    • Test your implementation

Merge instructions

  • Please merge after reviewing

Additional notes

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 17, 2024
@rtrieu rtrieu requested a review from a team as a code owner April 17, 2024 21:31
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@MaelNamNam MaelNamNam self-requested a review April 19, 2024 14:28
@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 26, 2024
@rtrieu
Copy link
Contributor Author

rtrieu commented Apr 26, 2024

Hi @MaelNamNam , this PR is ready for review!

rtrieu
rtrieu commented Apr 29, 2024
View reviewed changes
Copy link
Contributor Author

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting

content/en/real_user_monitoring/error_tracking/mobile/expo.md Outdated Show resolved Hide resolved
content/en/real_user_monitoring/error_tracking/mobile/reactnative.md Show resolved Hide resolved
@rtrieu rtrieu merged commit 621e4a2 into master Apr 30, 2024
12 checks passed
@rtrieu rtrieu deleted the rtrieu/rum-standardize-mobile-crash-report-setup-pages branch April 30, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 approved these changes

@MaelNamNam MaelNamNam Awaiting requested review from MaelNamNam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rtrieu @estherk15 @fuzzybinary @xgouchet @marco-saia-datadog