Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Profiler Images and Videos to Reflect New Nav #22705

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Update Profiler Images and Videos to Reflect New Nav #22705

merged 8 commits into from
Apr 19, 2024

Conversation

brett0000FF
Copy link
Contributor

What does this PR do? What is the motivation?

Merge instructions

  • Please merge after reviewing

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner April 17, 2024 18:21
@brett0000FF brett0000FF requested a review from gturbat April 17, 2024 18:21
@github-actions github-actions bot added Images Images are added/removed with this PR Guide Content impacting a guide labels Apr 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

gturbat
gturbat reviewed Apr 17, 2024
View reviewed changes
static/images/profiler/code_hotspots_tab-timeline.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a /GET train example, more interesting to see

static/images/profiler/endpoint_agg.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we use the CPU profile type instead?
  • I think we should hover the endpoint name on the right, to highlight that we filtered on it
  • We barely see the FG in this image, is there a vertical cropping or this is the full size of the screen?

static/images/profiler/endpoint_per_request.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep the video here, otherwise it is not clear how you end up here

@brett0000FF
Copy link
Contributor Author

@gturbat - Good suggestions. I updated the images for static/images/profiler/code_hotspots_tab-timeline.png and static/images/profiler/endpoint_agg.png. Please let me know how this looks now!

Also, I was struggling to find an interesting example to make the video for static/images/profiler/endpoint_per_request.png. Could you please help me grab a video for this one, without recording the left-nav ideally? Thanks!

rtrieu
rtrieu requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback, but otherwise looks good.

content/en/profiler/connect_traces_and_profiles.md Outdated Show resolved Hide resolved
@gturbat
Copy link
Contributor

gturbat commented Apr 18, 2024

@gturbat - Good suggestions. I updated the images for static/images/profiler/code_hotspots_tab-timeline.png and static/images/profiler/endpoint_agg.png. Please let me know how this looks now!

Also, I was struggling to find an interesting example to make the video for static/images/profiler/endpoint_per_request.png. Could you please help me grab a video for this one, without recording the left-nav ideally? Thanks!

@brett0000FF wdyt of this?
https://github.com/DataDog/documentation/assets/45032269/f66503b9-0e81-4b11-ae9d-ae17e2b82f94

@brett0000FF
Copy link
Contributor Author

brett0000FF commented Apr 18, 2024 •
edited
Loading

@brett0000FF wdyt of this? https://github.com/DataDog/documentation/assets/45032269/f66503b9-0e81-4b11-ae9d-ae17e2b82f94

@gturbat -- Oo, nice--that looks great. I can pop this new video back in place. Thanks! Edit: I added the video in. Let me know what you think!

@brett0000FF brett0000FF requested a review from rtrieu April 19, 2024 16:02
rtrieu
rtrieu approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brett0000FF brett0000FF merged commit f78f65f into master Apr 19, 2024
15 checks passed
@brett0000FF brett0000FF deleted the brett0000FF/profiler-nav-images branch April 19, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gturbat gturbat gturbat left review comments

@rtrieu rtrieu rtrieu approved these changes

Assignees
No one assigned
Labels
Guide Content impacting a guide Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brett0000FF @gturbat @rtrieu