Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDM][NDMII-2636]change the autodiscovery config #22695

Merged
merged 3 commits into from
Jun 27, 2024
Merged

[NDM][NDMII-2636]change the autodiscovery config #22695

merged 3 commits into from
Jun 27, 2024

Conversation

jedupau
Copy link
Contributor

@jedupau jedupau commented Apr 17, 2024

What does this PR do? What is the motivation?

Following those 3 prs : DataDog/datadog-agent#24644 DataDog/datadog-agent#24729 DataDog/datadog-agent#24724
I updated all the docs where snmp_listener was mentioned to replace it by network_devices.autodiscovery and removed the listeners: -snmp

Merge instructions

  • Please merge after reviewing

Additional notes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@jedupau jedupau changed the title [NDM][NDMII-2636]change the autodiscovery config [NDM][NDMII-2636][DO NOT MERGE]change the autodiscovery config Apr 17, 2024
@jedupau jedupau added the Do Not Merge Just do not merge this PR :) label Apr 17, 2024
@jedupau jedupau marked this pull request as ready for review June 27, 2024 16:09
@jedupau jedupau requested a review from a team as a code owner June 27, 2024 16:09
@jedupau jedupau removed the Do Not Merge Just do not merge this PR :) label Jun 27, 2024
@jedupau jedupau changed the title [NDM][NDMII-2636][DO NOT MERGE]change the autodiscovery config [NDM][NDMII-2636]change the autodiscovery config Jun 27, 2024
@hestonhoffman hestonhoffman merged commit 9addaf2 into master Jun 27, 2024
15 of 16 checks passed
@hestonhoffman hestonhoffman deleted the jed/change-autodiscovery-config branch June 27, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jedupau @cswatt @hestonhoffman