Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPSEC-52386] ASM ATO docs page #22497

Merged
merged 16 commits into from
Apr 16, 2024

Conversation

jkirsteins
Copy link
Contributor

Split from original PR: #22496

What does this PR do? What is the motivation?

This identifies our K9 capabilities for Account Takeover Protection. We will list 2 more use cases as distinct pages when this is approved in style.

Merge instructions

  • Please merge after reviewing

Additional notes

This documentation has a folder with images. The images should be replaced with better images [appropriate size] and the source folder deleted.
This documentation is purposefully applied to /security and not /security/asm as it focuses on a use case.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Preview links (active after the build_preview check completes)

New or renamed files

@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels Apr 4, 2024
@datamarmot datamarmot added the Do Not Merge Just do not merge this PR :) label Apr 4, 2024
@michaelcretzman michaelcretzman added the editorial review Waiting on a more in-depth review label Apr 11, 2024
@michaelcretzman michaelcretzman marked this pull request as ready for review April 11, 2024 21:33
@michaelcretzman michaelcretzman requested a review from a team as a code owner April 11, 2024 21:33
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised this for clarity and style. Waiting on doc peer review

content/en/security/account_takeover_protection.md Outdated Show resolved Hide resolved
content/en/security/account_takeover_protection.md Outdated Show resolved Hide resolved
content/en/security/account_takeover_protection.md Outdated Show resolved Hide resolved
content/en/security/account_takeover_protection.md Outdated Show resolved Hide resolved
content/en/security/account_takeover_protection.md Outdated Show resolved Hide resolved
content/en/security/account_takeover_protection.md Outdated Show resolved Hide resolved
content/en/security/account_takeover_protection.md Outdated Show resolved Hide resolved
static/images/security/ato/hosting.png Outdated Show resolved Hide resolved
static/images/security/ato/passlist.png Outdated Show resolved Hide resolved
static/images/security/ato/passlist2.png Outdated Show resolved Hide resolved
@jhgilbert
Copy link
Contributor

Hi @jkirsteins, I flagged some IP addresses that are visible in images, but if you know these are demo IPs that are fine to publish, we don't have to block them out. I wanted to let you know about a Chrome extension we often use on the docs team called Pawparazzi -- it lets you hide IP addresses in the browser without manually blurring them, and lets you put borders around elements in the screenshot.

@jhgilbert
Copy link
Contributor

@michaelcretzman I've finished my review, please review the suggestions and feel free to ignore any that don't work for you. Thank you!

incorporating peer review edits. Will incorp other suggestions in a subsequent commit.

Co-authored-by: Jen Gilbert <[email protected]>
michaelcretzman and others added 3 commits April 16, 2024 13:38
ticket: https://datadoghq.atlassian.net/browse/DOCS-7645

- incorporated final edits
- replaced images

- Still waiting for PM to inform me of release before publishing
Removing unneeded images that are from Staging
@michaelcretzman michaelcretzman removed Do Not Merge Just do not merge this PR :) editorial review Waiting on a more in-depth review labels Apr 16, 2024
@michaelcretzman michaelcretzman merged commit cb8188f into master Apr 16, 2024
14 of 17 checks passed
@michaelcretzman michaelcretzman deleted the michael_bentley/APPSEC-52386--only-ato branch April 16, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants