Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new Metrics Volume Management Doc #21935
Adding new Metrics Volume Management Doc #21935
Changes from 20 commits
192477b
8e1b096
26fcd11
132463b
189bea4
266d2cf
aebdcaa
9e996eb
112699b
9c33846
e30431b
1609cb7
1d8a07e
d8fb405
7c8efc0
1da4f50
deeabac
407fdd8
1c97434
c3c5821
c21ba8f
ab8e963
3369985
be425db
c877916
d2fbe69
d8624c5
44da270
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 21 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength
Check warning on line 25 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.words
Check warning on line 26 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.pronouns
Check warning on line 27 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.pronouns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to group these into one sentence? A short list of bullet points is easier to digest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we preserve it as 3 different questions? here's why:
Check warning on line 32 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.pronouns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the whole page, I'm not sure we need this section. Your headers are very clear in what a reader can expect to gain from the Metrics Volume, and adding this puts more friction for a user to scroll through. Let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agreed it adds a lot of overhead but we should assume that folks don't have patience to scroll vertically to read through the docs' headers -- an overview bulleted section of questions they can answer with this doc is present in other dd docs like logs' docs and other external docs too. Let's keep it
Check warning on line 35 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.words
Check warning on line 63 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.words
Check notice on line 69 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength
Check notice on line 69 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength
Check warning on line 69 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.words
Check warning on line 69 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.pronouns
Check notice on line 80 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength
Check warning on line 80 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.pronouns
Check warning on line 84 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.words
Check notice on line 86 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength
Check notice on line 86 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength
Check notice on line 86 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength
Check notice on line 102 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength
Check notice on line 102 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.oxfordcomma
Check notice on line 102 in content/en/metrics/volume.md
GitHub Actions / vale
Datadog.sentencelength