Fix handling of non integer response status code in AppSec #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Datadog ReportBranch report: ✅ 0 Failed, 22054 Passed, 1459 Skipped, 5m 54.09s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4175 +/- ##
=======================================
Coverage 97.75% 97.76%
=======================================
Files 1351 1351
Lines 81732 81733 +1
Branches 4146 4147 +1
=======================================
+ Hits 79899 79908 +9
+ Misses 1833 1825 -8 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-29 10:08:09 Comparing candidate commit 2c7b524 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
scenario:profiler - stack collector
|
7 tasks
Strech
approved these changes
Nov 29, 2024
Custom actions for AppSec can have status codes that are strings and not integers. We need to handle them properly.
y9v
force-pushed
the
appsec-handle-non-int-status-code
branch
from
01b06ef
to
b95a011
Compare
y9v
added a commit
that referenced
this pull request
Nov 29, 2024
Fix handling of non integer response status code in AppSec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom actions for AppSec can have status codes that are strings and not integers. We need to handle them properly.
What does this PR do?
This PR adds conversion of response status code for AppSec actions.
Motivation:
Failing system tests:
DataDog/system-tests#3586
Change log entry
None
Additional Notes:
None
How to test the change?
CI is enough