Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Deduplicate log entries #4154

Open
wants to merge 4 commits into
base: disable-env-logs
Choose a base branch
from
Open

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 23, 2024

This PR removes duplicate telemetry logs sent within the same batch (currently 10s). The number of occurrences is captured in the new count field for the Log telemetry event, so we can know how many events were removed as duplicated.

@github-actions github-actions bot added the core Involves Datadog core libraries label Nov 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 23, 2024

Benchmarks

Benchmark execution time: 2024-11-26 02:35:10

Comparing candidate commit 7a47b59 in PR branch dedup-logs with baseline commit 0c7a8c0 in branch disable-env-logs.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:library - Gem loading

  • 🟩 throughput [+0.137op/s; +0.144op/s] or [+5.121%; +5.413%]

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+2494.342op/s; +2579.313op/s] or [+8.179%; +8.458%]

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+8099.292op/s; +8463.716op/s] or [+7.344%; +7.674%]

@marcotc marcotc marked this pull request as ready for review November 26, 2024 01:56
@marcotc marcotc requested a review from a team as a code owner November 26, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant