Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gemspec dependencies #4152

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update gemspec dependencies #4152

wants to merge 3 commits into from

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 22, 2024

Motivation:

Leverage our scheduled job to update gemspec specific dependencies such as msgapck

What does this PR do?

  1. Add a rake task edge:gemspec to update gemspec specific dependencies to all gemfiles belongs to current runtime
  2. Introduce edge:gemspec into our schedule automation
  3. Remove obsolete ffi constraint for Ruby 3.4 and validate the task implementation

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 22, 2024 22:40
@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024

Benchmarks

Benchmark execution time: 2024-11-22 23:20:56

Comparing candidate commit 093141c in PR branch tonycthsu/update-deps with baseline commit 791f9db in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (791f9db) to head (093141c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4152      +/-   ##
==========================================
- Coverage   97.79%   97.78%   -0.01%     
==========================================
  Files        1350     1350              
  Lines       81327    81328       +1     
  Branches     4107     4107              
==========================================
- Hits        79530    79527       -3     
- Misses       1797     1801       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants