Address psych flaky test #4144
Closed
Address psych flaky test #4144
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-11-21 19:52:42 Comparing candidate commit 0cdba56 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4144 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1350 1350
Lines 81322 81322
Branches 4107 4107
=======================================
+ Hits 79515 79516 +1
+ Misses 1807 1806 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Improved by #4145! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
psychgem to the cucumber loading script and uninstallspsychbefore the script runs.Motivation:
The goal of this PR is to address a flaky test caused by the
psychgem double loading. @p-datadog includes details in #4130. Per Oleg's findings, the built-inpsychgem attempts to override the local/bundle gem. The error is caused whenlib/psych/class_loader.rbis loaded for the second time. This solution first uninstallspsychbefore reinstalling it in the cucumber loading script in order to avoid the double-load error; however, it does not address the original gem load.Change log entry
No change log entry.
Additional Notes:
This PR addresses the @DataDog/ruby-guild issue here.
How to test the change?
Given the nature of flakiness, I am testing the change through a Green CI and following up to confirm that no more flaky tests related to the
psychgem double-loading occur throughout the repo.