Guard injection against old rubies #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4140 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1353 1353
Lines 81820 81820
Branches 4145 4145
=======================================
+ Hits 79997 79999 +2
+ Misses 1823 1821 -2 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-27 13:30:19 Comparing candidate commit f9aec1a in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
p-datadog
reviewed
Nov 21, 2024
TonyCTHsu
requested changes
Nov 22, 2024
lloeki
force-pushed
the
lloeki/guard-injection-against-old-rubies
branch
2 times, most recently
from
ff2bea5
to
afe6b26
Compare
lloeki
commented
Nov 22, 2024
TonyCTHsu
approved these changes
Nov 22, 2024
These versions may be unable to execute - or even parse - the main host injection script.
lloeki
force-pushed
the
lloeki/guard-injection-against-old-rubies
branch
from
50fa474
to
f9aec1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a known-processable frontend script to the main injection script.
Motivation:
Main injection script may be attempted to be loaded via
RUBYOPT=-r'/path/to/host_inject.rb'but be unprocessable.Change log entry
Add safe NOOP injection script for very old rubies
Additional Notes:
How to test the change?