[NO-TICKET] Relax profiling CODEOWNERS configuration #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR relaxes the GitHub `CODEOWNERS` file rules for things related to profiling. Specifically, it adds `@DataDog/ruby-guild` as a second owner on top of just `@DataDog/profiling-rb`. **Motivation:** Now that we've enableed the "Require review from Code Owners" feature on GitHub, since there's not a lot of us working on profiling, it hasn't worked very well. Specifically, for very small PRs (#4072 is a good example where we slightly tweaked a test to avoid flakiness), it's annoying to have to wait for a very small reviewer pool, when most folks that are on the Ruby guild can help out review such changes. **Additional Notes:** N/A **How to test the change?** Check that future PRs affecting profiling can be merged with a review from anyone on the ruby-guild team.
ivoanjo
added
profiling
github-actions
bot
added
the
dev/github
TonyCTHsu
approved these changes
Nov 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4076 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.01%
==========================================
Files 1338 1338
Lines 80248 80248
Branches 4016 4016
==========================================
- Hits 78431 78425 -6
- Misses 1817 1823 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR relaxes the GitHub
CODEOWNERSfile rules for things related to profiling.Specifically, it adds
@DataDog/ruby-guildas a second owner on top of just@DataDog/profiling-rb.Motivation:
Now that we've enableed the "Require review from Code Owners" feature on GitHub, since there's not a lot of us working on profiling, it hasn't worked very well.
Specifically, for very small PRs (#4072 is a good example where we slightly tweaked a test to avoid flakiness), it's annoying to have to wait for a very small reviewer pool, when most folks that are on the Ruby guild can help out review such changes.
Change log entry
(Not relevant, internal change)
Additional Notes:
N/A
How to test the change?
Check that future PRs affecting profiling can be merged with a review from anyone on the ruby-guild team.