Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alejandro.gonzalez/security controls #7997

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Alejandro.gonzalez/security controls #7997

wants to merge 14 commits into from

Conversation

jandro996
Copy link
Member

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jandro996 jandro996 added the comp: asm iast Application Security Management (IAST) label Nov 22, 2024
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 bot reviewed Nov 22, 2024
View reviewed changes
internal-api/src/main/java/datadog/trace/api/iast/securitycontrol/SecurityControl.java

@Nullable
public String[] getParameterTypes() {
return parameterTypes;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Quality Violation

Do not return an array that is a class member (...read more)

Avoid returning an array that was defined as a class member. If you want to return an array or the values of the array that is a class member, consider returning a copy of the array.

View in Datadog  Leave us feedback  Documentation

@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/security-controls
git_commit_date 1732290365 1732293667
git_commit_sha 79ca6e4 c567536
release_version 1.43.0-SNAPSHOT~79ca6e471f 1.43.0-SNAPSHOT~c567536668
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732296290 1732296290
ci_job_id 717399713 717399713
ci_pipeline_id 49748966 49748966
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 1 performance regressions! Performance is the same for 49 metrics, 12 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:GlobalTracer better
[-35.909ms; -32.254ms] or [-8.251%; -7.412%]		 401.109ms 435.190ms
scenario:startup:petclinic:profiling:AppSec worse
[+1.155ms; +2.008ms] or [+2.149%; +3.737%]		 55.320ms 53.738ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~c567536668, baseline=1.43.0-SNAPSHOT~79ca6e471f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087000
Total [baseline] (10.44 s) : 0, 10439739
Agent [candidate] (1.092 s) : 0, 1092375
Total [candidate] (10.519 s) : 0, 10519012
section appsec
Agent [baseline] (1.223 s) : 0, 1222878
Total [baseline] (10.765 s) : 0, 10765433
Agent [candidate] (1.227 s) : 0, 1227441
Total [candidate] (10.716 s) : 0, 10715902
section iast
Agent [baseline] (1.227 s) : 0, 1226683
Total [baseline] (10.988 s) : 0, 10987712
Agent [candidate] (1.22 s) : 0, 1220092
Total [candidate] (10.951 s) : 0, 10950782
section profiling
Agent [baseline] (1.318 s) : 0, 1317676
Total [baseline] (10.833 s) : 0, 10833280
Agent [candidate] (1.288 s) : 0, 1287858
Total [candidate] (10.793 s) : 0, 10793340
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent appsec 1.223 s 135.879 ms (12.5%)
Agent iast 1.227 s 139.683 ms (12.9%)
Agent profiling 1.318 s 230.676 ms (21.2%)
Total tracing 10.44 s -
Total appsec 10.765 s 325.694 ms (3.1%)
Total iast 10.988 s 547.973 ms (5.2%)
Total profiling 10.833 s 393.541 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.227 s 135.066 ms (12.4%)
Agent iast 1.22 s 127.716 ms (11.7%)
Agent profiling 1.288 s 195.483 ms (17.9%)
Total tracing 10.519 s -
Total appsec 10.716 s 196.89 ms (1.9%)
Total iast 10.951 s 431.769 ms (4.1%)
Total profiling 10.793 s 274.328 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~c567536668, baseline=1.43.0-SNAPSHOT~79ca6e471f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.459 ms) : 0, 690459
BytebuddyAgent [candidate] (696.728 ms) : 0, 696728
GlobalTracer [baseline] (317.088 ms) : 0, 317088
GlobalTracer [candidate] (317.147 ms) : 0, 317147
AppSec [baseline] (54.463 ms) : 0, 54463
AppSec [candidate] (54.761 ms) : 0, 54761
Remote Config [baseline] (685.218 µs) : 0, 685
Remote Config [candidate] (705.993 µs) : 0, 706
Telemetry [baseline] (10.654 ms) : 0, 10654
Telemetry [candidate] (9.253 ms) : 0, 9253
section appsec
BytebuddyAgent [baseline] (709.347 ms) : 0, 709347
BytebuddyAgent [candidate] (712.727 ms) : 0, 712727
GlobalTracer [baseline] (314.335 ms) : 0, 314335
GlobalTracer [candidate] (315.105 ms) : 0, 315105
AppSec [baseline] (166.539 ms) : 0, 166539
AppSec [candidate] (166.551 ms) : 0, 166551
Remote Config [baseline] (648.887 µs) : 0, 649
Remote Config [candidate] (642.16 µs) : 0, 642
Telemetry [baseline] (8.563 ms) : 0, 8563
Telemetry [candidate] (8.269 ms) : 0, 8269
IAST [baseline] (19.586 ms) : 0, 19586
IAST [candidate] (20.832 ms) : 0, 20832
section iast
BytebuddyAgent [baseline] (816.726 ms) : 0, 816726
BytebuddyAgent [candidate] (811.572 ms) : 0, 811572
GlobalTracer [baseline] (308.663 ms) : 0, 308663
GlobalTracer [candidate] (307.896 ms) : 0, 307896
AppSec [baseline] (58.453 ms) : 0, 58453
AppSec [candidate] (58.303 ms) : 0, 58303
Remote Config [baseline] (613.764 µs) : 0, 614
Remote Config [candidate] (601.558 µs) : 0, 602
Telemetry [baseline] (7.533 ms) : 0, 7533
Telemetry [candidate] (7.401 ms) : 0, 7401
IAST [baseline] (20.927 ms) : 0, 20927
IAST [candidate] (20.59 ms) : 0, 20590
section profiling
BytebuddyAgent [baseline] (688.093 ms) : 0, 688093
BytebuddyAgent [candidate] (686.157 ms) : 0, 686157
GlobalTracer [baseline] (435.19 ms) : 0, 435190
GlobalTracer [candidate] (401.109 ms) : 0, 401109
AppSec [baseline] (53.738 ms) : 0, 53738
AppSec [candidate] (55.32 ms) : 0, 55320
Remote Config [baseline] (657.197 µs) : 0, 657
Remote Config [candidate] (1.994 ms) : 0, 1994
Telemetry [baseline] (7.691 ms) : 0, 7691
Telemetry [candidate] (12.936 ms) : 0, 12936
ProfilingAgent [baseline] (93.296 ms) : 0, 93296
ProfilingAgent [candidate] (91.28 ms) : 0, 91280
Profiling [baseline] (93.32 ms) : 0, 93320
Profiling [candidate] (91.303 ms) : 0, 91303
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~c567536668, baseline=1.43.0-SNAPSHOT~79ca6e471f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089891
Total [baseline] (8.734 s) : 0, 8734355
Agent [candidate] (1.101 s) : 0, 1101314
Total [candidate] (8.663 s) : 0, 8662790
section iast
Agent [baseline] (1.225 s) : 0, 1225129
Total [baseline] (9.245 s) : 0, 9245388
Agent [candidate] (1.215 s) : 0, 1214828
Total [candidate] (9.194 s) : 0, 9193875
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1218237
Total [baseline] (9.192 s) : 0, 9191856
Agent [candidate] (1.217 s) : 0, 1217372
Total [candidate] (9.202 s) : 0, 9202259
section iast_TELEMETRY_OFF
Agent [baseline] (1.224 s) : 0, 1223559
Total [baseline] (9.189 s) : 0, 9188692
Agent [candidate] (1.213 s) : 0, 1213357
Total [candidate] (9.188 s) : 0, 9188036
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent iast 1.225 s 135.239 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.218 s 128.346 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.224 s 133.668 ms (12.3%)
Total tracing 8.734 s -
Total iast 9.245 s 511.033 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.192 s 457.501 ms (5.2%)
Total iast_TELEMETRY_OFF 9.189 s 454.337 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.101 s -
Agent iast 1.215 s 113.514 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.217 s 116.058 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.213 s 112.043 ms (10.2%)
Total tracing 8.663 s -
Total iast 9.194 s 531.085 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.202 s 539.468 ms (6.2%)
Total iast_TELEMETRY_OFF 9.188 s 525.246 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~c567536668, baseline=1.43.0-SNAPSHOT~79ca6e471f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.469 ms) : 0, 692469
BytebuddyAgent [candidate] (701.494 ms) : 0, 701494
GlobalTracer [baseline] (317.266 ms) : 0, 317266
GlobalTracer [candidate] (320.098 ms) : 0, 320098
AppSec [baseline] (55.181 ms) : 0, 55181
AppSec [candidate] (55.047 ms) : 0, 55047
Remote Config [baseline] (688.85 µs) : 0, 689
Remote Config [candidate] (704.466 µs) : 0, 704
Telemetry [baseline] (10.584 ms) : 0, 10584
Telemetry [candidate] (10.113 ms) : 0, 10113
section iast
BytebuddyAgent [baseline] (814.541 ms) : 0, 814541
BytebuddyAgent [candidate] (808.231 ms) : 0, 808231
GlobalTracer [baseline] (309.445 ms) : 0, 309445
GlobalTracer [candidate] (306.35 ms) : 0, 306350
AppSec [baseline] (57.424 ms) : 0, 57424
AppSec [candidate] (57.867 ms) : 0, 57867
IAST [baseline] (21.778 ms) : 0, 21778
IAST [candidate] (20.634 ms) : 0, 20634
Remote Config [baseline] (626.277 µs) : 0, 626
Remote Config [candidate] (604.681 µs) : 0, 605
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.47 ms) : 0, 7470
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (810.338 ms) : 0, 810338
BytebuddyAgent [candidate] (809.686 ms) : 0, 809686
GlobalTracer [baseline] (306.632 ms) : 0, 306632
GlobalTracer [candidate] (306.652 ms) : 0, 306652
AppSec [baseline] (58.553 ms) : 0, 58553
AppSec [candidate] (58.194 ms) : 0, 58194
IAST [baseline] (20.898 ms) : 0, 20898
IAST [candidate] (20.985 ms) : 0, 20985
Remote Config [baseline] (620.48 µs) : 0, 620
Remote Config [candidate] (613.534 µs) : 0, 614
Telemetry [baseline] (7.487 ms) : 0, 7487
Telemetry [candidate] (7.536 ms) : 0, 7536
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (813.759 ms) : 0, 813759
BytebuddyAgent [candidate] (806.346 ms) : 0, 806346
GlobalTracer [baseline] (309.531 ms) : 0, 309531
GlobalTracer [candidate] (306.528 ms) : 0, 306528
AppSec [baseline] (57.999 ms) : 0, 57999
AppSec [candidate] (57.481 ms) : 0, 57481
IAST [baseline] (20.458 ms) : 0, 20458
IAST [candidate] (21.282 ms) : 0, 21282
Remote Config [baseline] (624.014 µs) : 0, 624
Remote Config [candidate] (641.483 µs) : 0, 641
Telemetry [baseline] (7.406 ms) : 0, 7406
Telemetry [candidate] (7.39 ms) : 0, 7390
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-22T16:56:05 2024-11-22T17:03:03
git_branch master alejandro.gonzalez/security-controls
git_commit_date 1732290365 1732293667
git_commit_sha 79ca6e4 c567536
release_version 1.43.0-SNAPSHOT~79ca6e471f 1.43.0-SNAPSHOT~c567536668
start_time 2024-11-22T16:55:52 2024-11-22T17:02:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732295338 1732295338
ci_job_id 717399714 717399714
ci_pipeline_id 49748966 49748966
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~c567536668, baseline=1.43.0-SNAPSHOT~79ca6e471f
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.343 µs) : 355, 394
.   : milestone, 374,
iast (485.136 µs) : 464, 506
.   : milestone, 485,
iast_FULL (647.308 µs) : 626, 669
.   : milestone, 647,
iast_GLOBAL (514.724 µs) : 492, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (485.855 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (445.606 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (482.39 µs) : 461, 504
.   : milestone, 482,
tracing (447.021 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (380.029 µs) : 360, 400
.   : milestone, 380,
iast (487.66 µs) : 466, 510
.   : milestone, 488,
iast_FULL (654.135 µs) : 633, 676
.   : milestone, 654,
iast_GLOBAL (513.941 µs) : 492, 536
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (486.036 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (448.112 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (482.976 µs) : 461, 505
.   : milestone, 483,
tracing (444.53 µs) : 424, 465
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.343 µs [354.62 µs, 394.066 µs] -
iast 485.136 µs [464.002 µs, 506.27 µs] 110.793 µs (29.6%)
iast_FULL 647.308 µs [625.828 µs, 668.788 µs] 272.965 µs (72.9%)
iast_GLOBAL 514.724 µs [492.341 µs, 537.107 µs] 140.381 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 485.855 µs [464.722 µs, 506.989 µs] 111.513 µs (29.8%)
iast_INACTIVE 445.606 µs [425.073 µs, 466.14 µs] 71.264 µs (19.0%)
iast_TELEMETRY_OFF 482.39 µs [460.665 µs, 504.114 µs] 108.047 µs (28.9%)
tracing 447.021 µs [426.376 µs, 467.666 µs] 72.678 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.029 µs [359.884 µs, 400.174 µs] -
iast 487.66 µs [465.554 µs, 509.766 µs] 107.631 µs (28.3%)
iast_FULL 654.135 µs [632.515 µs, 675.755 µs] 274.106 µs (72.1%)
iast_GLOBAL 513.941 µs [492.002 µs, 535.88 µs] 133.912 µs (35.2%)
iast_HARDCODED_SECRET_DISABLED 486.036 µs [465.013 µs, 507.059 µs] 106.007 µs (27.9%)
iast_INACTIVE 448.112 µs [427.091 µs, 469.133 µs] 68.083 µs (17.9%)
iast_TELEMETRY_OFF 482.976 µs [460.99 µs, 504.963 µs] 102.947 µs (27.1%)
tracing 444.53 µs [423.909 µs, 465.15 µs] 64.501 µs (17.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~c567536668, baseline=1.43.0-SNAPSHOT~79ca6e471f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1363
.   : milestone, 1344,
appsec (1.76 ms) : 1734, 1785
.   : milestone, 1760,
appsec_no_iast (1.754 ms) : 1729, 1780
.   : milestone, 1754,
iast (1.501 ms) : 1479, 1523
.   : milestone, 1501,
profiling (1.537 ms) : 1512, 1561
.   : milestone, 1537,
tracing (1.485 ms) : 1460, 1509
.   : milestone, 1485,
section candidate
no_agent (1.361 ms) : 1341, 1380
.   : milestone, 1361,
appsec (1.776 ms) : 1752, 1800
.   : milestone, 1776,
appsec_no_iast (1.735 ms) : 1710, 1760
.   : milestone, 1735,
iast (1.5 ms) : 1478, 1522
.   : milestone, 1500,
profiling (1.55 ms) : 1525, 1574
.   : milestone, 1550,
tracing (1.483 ms) : 1458, 1508
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.363 ms] -
appsec 1.76 ms [1.734 ms, 1.785 ms] 415.724 µs (30.9%)
appsec_no_iast 1.754 ms [1.729 ms, 1.78 ms] 410.378 µs (30.5%)
iast 1.501 ms [1.479 ms, 1.523 ms] 157.163 µs (11.7%)
profiling 1.537 ms [1.512 ms, 1.561 ms] 192.785 µs (14.3%)
tracing 1.485 ms [1.46 ms, 1.509 ms] 140.616 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.341 ms, 1.38 ms] -
appsec 1.776 ms [1.752 ms, 1.8 ms] 415.002 µs (30.5%)
appsec_no_iast 1.735 ms [1.71 ms, 1.76 ms] 374.439 µs (27.5%)
iast 1.5 ms [1.478 ms, 1.522 ms] 139.217 µs (10.2%)
profiling 1.55 ms [1.525 ms, 1.574 ms] 188.977 µs (13.9%)
tracing 1.483 ms [1.458 ms, 1.508 ms] 122.349 µs (9.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/security-controls
git_commit_date 1732290365 1732293667
git_commit_sha 79ca6e4 c567536
release_version 1.43.0-SNAPSHOT~79ca6e471f 1.43.0-SNAPSHOT~c567536668
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732295884 1732295884
ci_job_id 717399715 717399715
ci_pipeline_id 49748966 49748966
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~c567536668, baseline=1.43.0-SNAPSHOT~79ca6e471f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
.   : milestone, 1461,
appsec (2.312 ms) : 2272, 2353
.   : milestone, 2312,
iast (2.069 ms) : 2017, 2121
.   : milestone, 2069,
iast_GLOBAL (2.112 ms) : 2060, 2164
.   : milestone, 2112,
profiling (1.93 ms) : 1888, 1971
.   : milestone, 1930,
tracing (1.907 ms) : 1868, 1947
.   : milestone, 1907,
section candidate
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.307 ms) : 2266, 2347
.   : milestone, 2307,
iast (2.074 ms) : 2022, 2126
.   : milestone, 2074,
iast_GLOBAL (2.114 ms) : 2062, 2167
.   : milestone, 2114,
profiling (1.957 ms) : 1915, 2000
.   : milestone, 1957,
tracing (1.913 ms) : 1873, 1953
.   : milestone, 1913,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.45 ms, 1.473 ms] -
appsec 2.312 ms [2.272 ms, 2.353 ms] 851.103 µs (58.2%)
iast 2.069 ms [2.017 ms, 2.121 ms] 607.449 µs (41.6%)
iast_GLOBAL 2.112 ms [2.06 ms, 2.164 ms] 650.448 µs (44.5%)
profiling 1.93 ms [1.888 ms, 1.971 ms] 468.328 µs (32.0%)
tracing 1.907 ms [1.868 ms, 1.947 ms] 445.969 µs (30.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.307 ms [2.266 ms, 2.347 ms] 842.952 µs (57.6%)
iast 2.074 ms [2.022 ms, 2.126 ms] 610.567 µs (41.7%)
iast_GLOBAL 2.114 ms [2.062 ms, 2.167 ms] 650.627 µs (44.5%)
profiling 1.957 ms [1.915 ms, 2.0 ms] 493.874 µs (33.7%)
tracing 1.913 ms [1.873 ms, 1.953 ms] 449.52 µs (30.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~c567536668, baseline=1.43.0-SNAPSHOT~79ca6e471f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.386 s) : 15386000, 15386000
.   : milestone, 15386000,
appsec (15.17 s) : 15170000, 15170000
.   : milestone, 15170000,
iast (18.685 s) : 18685000, 18685000
.   : milestone, 18685000,
iast_GLOBAL (17.699 s) : 17699000, 17699000
.   : milestone, 17699000,
profiling (15.87 s) : 15870000, 15870000
.   : milestone, 15870000,
tracing (14.659 s) : 14659000, 14659000
.   : milestone, 14659000,
section candidate
no_agent (15.292 s) : 15292000, 15292000
.   : milestone, 15292000,
appsec (14.862 s) : 14862000, 14862000
.   : milestone, 14862000,
iast (18.614 s) : 18614000, 18614000
.   : milestone, 18614000,
iast_GLOBAL (18.251 s) : 18251000, 18251000
.   : milestone, 18251000,
profiling (14.99 s) : 14990000, 14990000
.   : milestone, 14990000,
tracing (14.792 s) : 14792000, 14792000
.   : milestone, 14792000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.386 s [15.386 s, 15.386 s] -
appsec 15.17 s [15.17 s, 15.17 s] -216.0 ms (-1.4%)
iast 18.685 s [18.685 s, 18.685 s] 3.299 s (21.4%)
iast_GLOBAL 17.699 s [17.699 s, 17.699 s] 2.313 s (15.0%)
profiling 15.87 s [15.87 s, 15.87 s] 484.0 ms (3.1%)
tracing 14.659 s [14.659 s, 14.659 s] -727.0 ms (-4.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.292 s [15.292 s, 15.292 s] -
appsec 14.862 s [14.862 s, 14.862 s] -430.0 ms (-2.8%)
iast 18.614 s [18.614 s, 18.614 s] 3.322 s (21.7%)
iast_GLOBAL 18.251 s [18.251 s, 18.251 s] 2.959 s (19.3%)
profiling 14.99 s [14.99 s, 14.99 s] -302.0 ms (-2.0%)
tracing 14.792 s [14.792 s, 14.792 s] -500.0 ms (-3.3%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jandro996