Fix example projects #776
Draft
Fix example projects #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade react-native to version 0.74.6 - Update project dependencies - Fix metro & babel configs - Upgrade gradle version - Increase minSdkVersion & ndkVersion - Update 'WixApp' component to access 'Navigation' object from '@datadog/mobile-react-native-navigation'
…rade - Upgrade react-native to version 0.74.6 - Update project dependencies - Fix metro config - Upgrade gradle version - Increase minSdkVersion & ndkVersion - Remove flipper initialization & refactor 'MainApplication.kt' - Rename 'getBundleURL' to 'bundleURL' in 'AppDelegate.mm'
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Comment on lines
+15
to
+20
| const viewPredicate: ViewNamePredicate = function customViewNamePredicate( | ||
| _event: ComponentDidAppearEvent, | ||
| trackedName: string | ||
| ) { | ||
| return 'Custom RNN ' + trackedName; | ||
| }; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Function name 'customViewNamePredicate' should match name 'viewPredicate'. (...read more)
Use the same name between your function declaration and the variable or property to which it is assigned.
Datadog ReportBranch report: ✅ 0 Failed, 630 Passed, 1 Skipped, 12.04s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix both example and example-new-architecture and update projects to latest supported react-native version.