Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUM-7629] Expose method generateUUID in DdRUM #749

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[RUM-7629] Expose method generateUUID in DdRUM #749

merged 1 commit into from
Dec 17, 2024
+37 −0

Conversation

marco-saia-datadog
Copy link
Member

@marco-saia-datadog marco-saia-datadog commented Dec 16, 2024 •
edited
Loading

What it does?

  • Exposes the generateUUID in DdRUM.

Motivation

  • If a user wants to generate an trace/span id on the headers to custom inject, it will require to generate a UUID that complies with trace context propagation. This change will enable to easily retrieve the UUID.

Additional Notes

A copy of the original PR: #746 by @jhssilva

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review December 16, 2024 13:43
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner December 16, 2024 13:43
@marco-saia-datadog marco-saia-datadog force-pushed the hugo.silva/expose-generate-uuid branch from ebbc59c to 19e9120 Compare December 16, 2024 13:44
@marco-saia-datadog marco-saia-datadog mentioned this pull request Dec 16, 2024
Closed
4 tasks
@marco-saia-datadog marco-saia-datadog merged commit 2f4eee5 into develop Dec 17, 2024
11 checks passed
@marco-saia-datadog marco-saia-datadog deleted the hugo.silva/expose-generate-uuid branch December 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgouchet xgouchet xgouchet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marco-saia-datadog @xgouchet @jhssilva