Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUM-7018] ANDROID: Support SR Image Recording #743

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[RUM-7018] ANDROID: Support SR Image Recording #743

merged 1 commit into from
Dec 19, 2024

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Adds support for Session Replay image recording on Android by implementing a custom ReactImageViewMapper.

Additional Notes

These changes depend on this Android SDK PR: DataDog/dd-sdk-android#2435

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-7018/support-image-recording branch from baf0cfa to 7914474 Compare December 9, 2024 09:11
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-7018/support-image-recording branch from 7914474 to f604781 Compare December 18, 2024 15:12
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 18, 2024 •
edited
Loading

Datadog Report

Branch report: marcosaia/RUM-7018/support-image-recording
Commit report: e3a9a76
Test service: dd-sdk-reactnative

✅ 0 Failed, 629 Passed, 1 Skipped, 13.39s Total Time

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-7018/support-image-recording branch from f604781 to e3a9a76 Compare December 18, 2024 15:24
@marco-saia-datadog marco-saia-datadog merged commit e3a9a76 into develop Dec 19, 2024
10 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-7018/support-image-recording branch December 19, 2024 15:59
@jonathanmos jonathanmos mentioned this pull request Dec 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marco-saia-datadog