Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal testing assertions for android #603

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Fix internal testing assertions for android #603

merged 3 commits into from
Feb 2, 2024

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Adds a few fixes after testing more scenarios with assertions.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner February 1, 2024 16:40
@louiszawadzki louiszawadzki merged commit 475c1f6 into develop Feb 2, 2024
4 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/rum-2345/fix-assertions branch February 2, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshnj ganeshnj ganeshnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louiszawadzki @ganeshnj