Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default SR sample rate to 0 #582

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Set default SR sample rate to 0 #582

merged 3 commits into from
Jan 12, 2024

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Sets default SR sample rate to 0 to match behaviour on other SDKs.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner January 10, 2024 14:57
@louiszawadzki louiszawadzki force-pushed the louiszawadzki/set-default-sr-sample-rate-to-0 branch from 992c6c9 to 5ee3204 Compare January 10, 2024 16:36
@louiszawadzki louiszawadzki force-pushed the louiszawadzki/set-default-sr-sample-rate-to-0 branch from 5ee3204 to 118c92e Compare January 12, 2024 14:29
@louiszawadzki louiszawadzki merged commit 8f71368 into develop Jan 12, 2024
4 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/set-default-sr-sample-rate-to-0 branch January 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louiszawadzki @0xnm