Remove usage of node for finding RN in gradle #580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove usage of node for finding RN in gradle.
The previous solution was triggering an error that was hard to understand when
node
could not be found: #575For context, this change was originally introduced when migrating to RN 0.71 to keep retro-compatibility for earlier RN versions.
Additional Notes
I believe the proposed solution is the current best practice to get the path to node modules in gradle, I've seen it used in big community packages:
Review checklist (to be filled by reviewers)