Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of node for finding RN in gradle #580

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Remove usage of node for finding RN in gradle.
The previous solution was triggering an error that was hard to understand when node could not be found: #575

For context, this change was originally introduced when migrating to RN 0.71 to keep retro-compatibility for earlier RN versions.

Additional Notes

I believe the proposed solution is the current best practice to get the path to node modules in gradle, I've seen it used in big community packages:

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner January 4, 2024 09:33
@louiszawadzki louiszawadzki merged commit e57805b into develop Jan 4, 2024
4 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/rum-2589/improve-rn-detection-without-node branch January 4, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants