Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document hybrid apps with SDK v2 #576

Merged

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Use SDK v2 in hybrid apps support document.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested review from a team as code owners December 22, 2023 08:34
buraizu
buraizu previously approved these changes Dec 22, 2023
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approving with some minor feedback and clarification

docs/hybrid_applications.md Outdated Show resolved Hide resolved
docs/hybrid_applications.md Outdated Show resolved Hide resolved
docs/hybrid_applications.md Outdated Show resolved Hide resolved
0xnm
0xnm previously approved these changes Dec 26, 2023
jonathanmos
jonathanmos previously approved these changes Jan 3, 2024
@louiszawadzki louiszawadzki dismissed stale reviews from jonathanmos, 0xnm, and buraizu via 71bfb3f January 3, 2024 10:14
@louiszawadzki louiszawadzki requested a review from 0xnm January 3, 2024 10:15
@louiszawadzki louiszawadzki merged commit 8884d04 into develop Jan 3, 2024
4 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/rum-2527/use-sdk-v2-in-hybrid-apps branch January 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants