Implement Masking for Android SR text #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmos
changed the base branch from
develop
to
jmoskovich/rum-1817/record-android-text
jonathanmos
force-pushed
the
jmoskovich/rum-1817/record-android-text
branch
from
bdce711 to
7cc8400
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-1817/android-masking
branch
3 times, most recently
from
5d0c7e1 to
6e0cb25
Compare
Base automatically changed from
jmoskovich/rum-1817/record-android-text
to
develop
December 21, 2023 10:18
jonathanmos
force-pushed
the
jmoskovich/rum-1817/android-masking
branch
3 times, most recently
from
b75d175 to
7505112
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-1817/android-masking
branch
from
7505112 to
4bcd6a2
Compare
jonathanmos
changed the title
0xnm
reviewed
Dec 26, 2023
...id/src/main/kotlin/com/datadog/reactnative/sessionreplay/mappers/ReactMaskInputTextMapper.kt
Outdated
Show resolved
Hide resolved
...lay/android/src/test/kotlin/com/datadog/reactnative/sessionreplay/utils/TextViewUtilsTest.kt
Outdated
Show resolved
Hide resolved
jonathanmos
force-pushed
the
jmoskovich/rum-1817/android-masking
branch
from
4bcd6a2 to
39ee8f7
Compare
0xnm
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds MASK and MASK_INPUT for text on android, and updates the android sdk native dependency to 2.4.0.
Screenshots from replays:
With masking:
With mask user input:
Motivation
Necessary for supporting textviews in Android Session Replay.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)