Add support for Android view capturing in Session Replay #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ReactViewGroupMapper.kt
Outdated
Show resolved
Hide resolved
...replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ReactViewGroupMapper.kt
Outdated
Show resolved
Hide resolved
...replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ReactViewGroupMapper.kt
Outdated
Show resolved
Hide resolved
...e-session-replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ColorUtils.kt
Outdated
Show resolved
Hide resolved
...ssion-replay/android/src/test/kotlin/com/datadog/reactnative/sessionreplay/ColorUtilsTest.kt
Outdated
Show resolved
Hide resolved
|
Can you add screenshots of the nigthly app to see what it looks like? Also I don't see anything around the |
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
3 times, most recently
from
c9faa9d to
65f5785
Compare
...replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ReactViewGroupMapper.kt
Outdated
Show resolved
Hide resolved
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
from
65f5785 to
38c508a
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
2 times, most recently
from
9a76ff7 to
c63ffcb
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
from
c63ffcb to
d380eb8
Compare
louiszawadzki
previously approved these changes
Nov 29, 2023
0xnm
reviewed
Nov 29, 2023
...e-session-replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ColorUtils.kt
Outdated
Show resolved
Hide resolved
...e-session-replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ColorUtils.kt
Outdated
Show resolved
Hide resolved
...replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ReactViewGroupMapper.kt
Outdated
Show resolved
Hide resolved
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
from
d380eb8 to
65b3d02
Compare
|
I refactored three files -> ColorUtils, ColorUtilsTest and ReactViewGroupMapper. The changes were quite extensive so could you please review those three again? Basically, I separated opacity and color alpha entirely as concepts and implemented a simpler method to calculate the rgba from the color int. I also removed the recursion for the opacity, because this logic is not used on the native side and the solution will either have to be on the player side, or on the native side perhaps will require an rfc |
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
2 times, most recently
from
ff6e7e9 to
c12e0da
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
from
c12e0da to
2874bf0
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
2 times, most recently
from
c81eb1e to
b3ff8d9
Compare
0xnm
reviewed
Nov 30, 2023
...e-session-replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ColorUtils.kt
Outdated
Show resolved
Hide resolved
...e-session-replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ColorUtils.kt
Outdated
Show resolved
Hide resolved
...e-session-replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ColorUtils.kt
Outdated
Show resolved
Hide resolved
...e-session-replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ColorUtils.kt
Outdated
Show resolved
Hide resolved
...replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ReactViewGroupMapper.kt
Show resolved
Hide resolved
...replay/android/src/main/kotlin/com/datadog/reactnative/sessionreplay/ReactViewGroupMapper.kt
Outdated
Show resolved
Hide resolved
0xnm
approved these changes
Nov 30, 2023
louiszawadzki
approved these changes
Nov 30, 2023
jonathanmos
force-pushed
the
jmoskovich/rum-1816/record-android-views
branch
from
039b17e to
7bed2b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for capturing Android views in Session Replay. Views are supported with the opacity prop or where specifying the opacity through a color with alpha (e.g. FF000000)
Support for border width and color, and for corner radius.
emulator:
replay:
With border and rounded corners.
emulator:
replay:
With parent with 10% opacity:
emulator
replay
Motivation
Part of the effort to add Session Replay to React Native.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)