RUM-7005: updating dependencies, adjusting detekt rules, fix tests #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satween
commented
Dec 18, 2024
| @@ -57,23 +58,17 @@ internal open class AndroidXFragmentLifecycleCallbacks( | |||
| } | |||
|
|
|||
| // endregion | |||
| override fun onFragmentViewCreated(fm: FragmentManager, f: Fragment, v: View, savedInstanceState: Bundle?) { | |||
satween
force-pushed
the
tvaleev/rum-7005/updating-android-navigation-dependencies
branch
from
ab4b2bc to
474a55b
Compare
xgouchet
approved these changes
Dec 19, 2024
| @@ -57,23 +58,17 @@ internal open class AndroidXFragmentLifecycleCallbacks( | |||
| } | |||
|
|
|||
| // endregion | |||
| override fun onFragmentViewCreated(fm: FragmentManager, f: Fragment, v: View, savedInstanceState: Bundle?) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We’re updating androidx.navigation to 2.8.0. Our goal is to maintain a balance between using stable library versions and minimizing disruptive changes to our customers’ codebases.
Motivation
This update motivated by contributor request
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)