RUM-7216: Add Slider semantics node mapper #2459
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satween
reviewed
Dec 18, 2024
| @@ -148,6 +152,8 @@ internal class RootSemanticsNodeMapper( | |||
| textFieldSemanticsNodeMapper | |||
There was a problem hiding this comment.
Tip
Maybe worth to use when here?
| ): SemanticsWireframe { | ||
| var index = 0 | ||
| val trackWireframe = resolveTrackWireframe(parentContext, semanticsNode, index++) | ||
| val thumbWireframe = resolveThumbWireframe(parentContext, semanticsNode, index) |
There was a problem hiding this comment.
Tip
Seems like could use 0 and 1 directly instead of index
| val globalBounds = resolveBounds(semanticsNode) | ||
| val progressBarRangeInfo = semanticsUtils.getProgressBarRangeInfo(semanticsNode) | ||
| val progress = progressBarRangeInfo?.let { | ||
| it.current / (it.range.endInclusive - it.range.start) |
There was a problem hiding this comment.
Warning
Are you sure that there is no chance for ArithmeticException here?
| val thumbHeight = DEFAULT_THUMB_RADIUS.value * 2 * parentContext.density | ||
| val yOffset = (globalBounds.height - thumbHeight).toLong() / 2 | ||
| println("prod thumb - height: ${globalBounds.height}, thumbHeight $thumbHeight") | ||
| println("test thumb - yOffset: $yOffset") |
|
|
||
| companion object { | ||
| // TODO RUM-7467: Use contrast color of parent color | ||
| private const val DEFAULT_COLOR = "#000000FF" |
There was a problem hiding this comment.
Tip
Probably it's better to put color name into the constant?
| val xOffset = fakeProgress * fakeGlobalBounds.width + fakeGlobalBounds.x | ||
| val thumbHeight = DEFAULT_THUMB_RADIUS.value * 2 * fakeUiContext.density | ||
| val expectedTrackWireframe = MobileSegment.Wireframe.ShapeWireframe( | ||
| id = (fakeSemanticsId.toLong() shl 32) + 0, |
There was a problem hiding this comment.
Note
It's not clear why we need shift here?
| ) | ||
| ) | ||
| val yThumbOffset = (fakeGlobalBounds.height - thumbHeight).toLong() / 2 | ||
| println("test thumb - height: ${fakeGlobalBounds.height}, thumbHeight $thumbHeight") |
There was a problem hiding this comment.
Note
same here, do we need this prints?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2459 +/- ##
===========================================
- Coverage 70.37% 70.30% -0.07%
===========================================
Files 780 781 +1
Lines 28850 28901 +51
Branches 4835 4839 +4
===========================================
+ Hits 20301 20317 +16
- Misses 7205 7233 +28
- Partials 1344 1351 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)