Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synthetics] Generate JSON schemas from interfaces #908

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Jun 2, 2023

💡 Better reviewed commit by commit

What and why?

We'd like to improve the developer experience when editing the datadog-ci.json file, or test files (aka. *.synthetics.json).

How?

Generate JSON schemas based on TypeScript interfaces with JSDoc, that IDEs can use to provide autocompletion.

And then add those JSON schemas to the corresponding repository: DataDog/schema#22

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 force-pushed the corentin.girard/SYNTH-3437/prepare-for-json-schemas-generation branch from 065e7f5 to 5506846 Compare June 2, 2023 16:02
@Drarig29 Drarig29 force-pushed the corentin.girard/fix-example-synthetics-global-config-file branch 2 times, most recently from 2aec1f7 to 8833f34 Compare June 14, 2023 13:32
Base automatically changed from corentin.girard/fix-example-synthetics-global-config-file to master June 15, 2023 08:23
@Drarig29 Drarig29 force-pushed the corentin.girard/SYNTH-3437/prepare-for-json-schemas-generation branch from 5506846 to 75ea0ef Compare June 19, 2023 16:39
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 19, 2023

Datadog Report

Branch report: corentin.girard/SYNTH-3437/prepare-for-json-schemas-generation
Commit report: f74f64d

datadog-ci-tests: 0 Failed, 0 New Flaky, 4314 Passed, 0 Skipped, 2m 55.5s Wall Time

@Drarig29 Drarig29 force-pushed the corentin.girard/SYNTH-3437/prepare-for-json-schemas-generation branch from 304a08f to f74f64d Compare June 21, 2023 13:59
@Drarig29 Drarig29 changed the title [synthetics] Prepare for JSON schemas generation [synthetics] Generate JSON schemas from interfaces Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant