Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-2181] Set a specific default timeout value when getting the flare for OTEL #31388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ogaca-dd
Copy link
Contributor

What does this PR do?

Set a specific default timeout value when getting the flare for OTEL

Motivation

Fix new-e2e-otel e2e tests.

Describe how to test/QA your changes

Run new-e2e-otel e2e tests.

Possible Drawbacks / Trade-offs

Additional Notes

@ogaca-dd ogaca-dd added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Nov 22, 2024
@ogaca-dd ogaca-dd requested review from a team as code owners November 22, 2024 16:26
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 22, 2024
@ogaca-dd ogaca-dd force-pushed the olivierg/otel-flare-missing-files branch from 6089c6c to dc93ea7 Compare November 22, 2024 16:28
@ogaca-dd ogaca-dd changed the title Set a specific default timeout value when getting the flare for OTEL [OTEL-2181] Set a specific default timeout value when getting the flare for OTEL Nov 22, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this line and see if the test is no longer flaky?

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49746782 --os-family=ubuntu

Note: This applies to commit dc93ea7

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ff601cf8-f867-4f1b-9d39-b56f99fa2b64

Baseline: bd961d3
Comparison: dc93ea7
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +3.79 [+0.32, +7.27] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.57 [+0.84, +2.31] 1 Logs
quality_gate_idle_all_features memory utilization +0.70 [+0.55, +0.84] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.11 [-0.72, +0.95] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.68, +0.87] 1 Logs
otel_to_otel_logs ingress throughput +0.02 [-0.62, +0.66] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.73, +0.78] 1 Logs
basic_py_check % cpu utilization +0.02 [-3.87, +3.91] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.61] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.09] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.27 [-0.74, +0.19] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.43 [-1.21, +0.36] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.94 [-1.01, -0.87] 1 Logs
quality_gate_idle memory utilization -1.11 [-1.19, -1.04] 1 Logs bounds checks dashboard
file_tree memory utilization -2.34 [-2.46, -2.22] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants