Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary context #4

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Remove unnecessary context #4

merged 1 commit into from
Jan 31, 2024

Conversation

jamesponddotco
Copy link
Collaborator

What does this PR do?

Remove an unnecessary context that was simply being copied around. Our internal do function should now match the one from Go's standard library.

Review checklist

Please check relevant items below:

  • The title & description contain a short meaningful summary of work completed.
  • Tests have been updated/created and are passing locally.
  • I've reviewed the CONTRIBUTING.md file.

@jamesponddotco jamesponddotco added the bug Something isn't working label Jan 30, 2024
@jamesponddotco jamesponddotco requested a review from a team January 30, 2024 15:48
@jamesponddotco jamesponddotco merged commit aab2bfd into trunk Jan 31, 2024
7 checks passed
@jamesponddotco jamesponddotco deleted the james.pond/remove-unnecessary-ctx branch January 31, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakutsuru hakutsuru hakutsuru approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesponddotco @hakutsuru