Optimize reading responses #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using io.Copy instead of io.ReadAll we reduce memory usage by about 50%. Signed-off-by: James Pond <[email protected]>
Signed-off-by: James Pond <[email protected]>
Signed-off-by: James Pond <[email protected]>
srividya-rajagopalan
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces
io.ReadAllwithio.Copyand a preallocated buffer, which decreases the number of allocations and usage happening in this portion of the code by up to 50%.This is a big win for extremelly large diagrams, while causing no issues with small diagrams.
Review checklist
Please check relevant items below: