PR for Cloudcraft Go SDK #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Pond <[email protected]>
jamesponddotco
requested review from
tjunnone,
srividya-rajagopalan,
Vesuri and
hakutsuru
Signed-off-by: James Pond <[email protected]>
tjunnone
reviewed
Dec 7, 2023
Per @tjunnone, the snapshot API will process the scan for up to 120 seconds per request before sending a continuation response, so that should probably be our default timeout value. * See: #1 (comment) Signed-off-by: James Pond <[email protected]>
Signed-off-by: James Pond <[email protected]>
Signed-off-by: James Pond <[email protected]>
Signed-off-by: Tomas Junnonen <[email protected]>
Explain the environment variable use in the example Signed-off-by: Tomas Junnonen <[email protected]>
Signed-off-by: James Pond <[email protected]>
tjunnone
previously approved these changes
Dec 13, 2023
Signed-off-by: James Pond <[email protected]>
tjunnone
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the initial version of the Go SDK for Cloudcraft, which seems to be passing all mock and integration tests.
Tests where written using a combination of manual work plus GPT-4, and the code itself was written using GitHub Copilot as my autocomplete engine on vim, so the review may need extra attention.