Clean up RecordDaoTest
#477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* beginning of python test * serve files from nginx
* Add RecordTypeSchema.getAttributeSchema * Comment argument names * Formatting
* Add DataTypeMapping.getBaseType * Add test for DataTypeMapping.getArrayTypeForBase * Refactor DataTypeMapping.getArrayTypeForBase * Add names for parameterized tests * Refactor configuration of base types and array types
* Add alternate constructors for AttributeSchema * Fix order of expected/actual values * Remove public modifiers * Add another test
Add prepareThreshold=0 to default JDBC configuration
* first pass one download --------- Co-authored-by: Josh Ladieu <[email protected]>
Spring Boot 3.2.2 / Spring Framework 6.1.3
* Add basic attribute data type conversions * Move test cases to separate class * Add explanations to some assertions * Use equals instead of == * Refactor supported data types * Refactor check for number <=> boolean conversions * Pass message to test helpers * Move test argument providers to RecordOrchestratorServiceTest * Handle additional error codes * Add comment * Remove support for array to scalar conversions
* Add tests for SQL expressions for data type conversions * Attempt to get as many of the args statements onto one line --------- Co-authored-by: Josh Ladieu <[email protected]>
|
I goofed up base branch on this. Replaced by #478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is maintenance cleanup/refactoring: AJ-1533, followup from
Clean up
RecordDaoTestnew HashMap<>(...)throughout.RecordAttributes.empty()tonew RecordAttributes(Map.of()).Collections.emptyMap()toMap.of().Note:
Collections.emptyMap()andMap.of()are not equivalent, see: https://stackoverflow.com/questions/46404933/map-of-vs-collections-emptymapWhile arguably
Map.of()is preferred where possible, I thinkemptyMap()is more readable and in tests I think readability matters more unlessMap.of()'s behavior is explicitly relevant to what's being tested.