Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AJ-1188 Add wds consumer tests against datarepo provider #378

Merged
merged 33 commits into from
Nov 9, 2023
Merged

AJ-1188 Add wds consumer tests against datarepo provider #378

merged 33 commits into from
Nov 9, 2023

Conversation

calypsomatic
Copy link
Contributor

@calypsomatic calypsomatic commented Oct 19, 2023 •
edited by jladieu
Loading

@calypsomatic calypsomatic marked this pull request as ready for review October 20, 2023 19:56
@calypsomatic calypsomatic changed the title Aj 1188 tdr consumer Aj 1188 Add wds-consumer tests against tdr-provider Oct 20, 2023
@calypsomatic calypsomatic changed the title Aj 1188 Add wds-consumer tests against tdr-provider AJ-1188 Add wds-consumer tests against tdr-provider Oct 20, 2023
okotsopoulos
okotsopoulos reviewed Nov 1, 2023
View reviewed changes
Copy link

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the home stretch!

service/src/test/java/org/databiosphere/workspacedataservice/pact/TDRPactTest.java Outdated Show resolved Hide resolved
service/src/test/java/org/databiosphere/workspacedataservice/pact/TDRPactTest.java Outdated Show resolved Hide resolved
service/src/test/java/org/databiosphere/workspacedataservice/pact/TDRPactTest.java Outdated Show resolved Hide resolved
service/src/test/java/org/databiosphere/workspacedataservice/pact/TDRPactTest.java Outdated Show resolved Hide resolved
@jladieu jladieu force-pushed the aj-1188-tdr-consumer branch from bd0f748 to 987a183 Compare November 8, 2023 15:40
okotsopoulos
okotsopoulos approved these changes Nov 8, 2023
View reviewed changes
Copy link

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much Bria and Josh for your work on this!

@jladieu , I have one request regarding the removal of a TDR provider state specification, but otherwise looks good to merge. I was able to massage things locally in TDR and see the published Pacts pass verification, so I know how I'll be updating my provider PR in flight.

service/src/test/java/org/databiosphere/workspacedataservice/pact/TDRPactTest.java Outdated Show resolved Hide resolved
service/src/test/java/org/databiosphere/workspacedataservice/pact/TDRPactTest.java Show resolved Hide resolved
@jladieu
Remove unneeded given specification.
7e45112 
TDR snapshot is guaranteed to have at least one table, no need to
declare this as part of a given.

Context:
#378 (comment)
@jladieu jladieu changed the title AJ-1188 Add wds-consumer tests against tdr-provider AJ-1188 Add wds consumer tests against datarepo provider Nov 9, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jladieu jladieu merged commit 028bced into main Nov 9, 2023
14 checks passed
@jladieu jladieu deleted the aj-1188-tdr-consumer branch November 9, 2023 14:57
@jladieu jladieu mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jladieu jladieu jladieu approved these changes

@okotsopoulos okotsopoulos okotsopoulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calypsomatic @jladieu @okotsopoulos