Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1234: Add WsmPactTest #372

Merged
merged 1 commit into from
Nov 2, 2023
Merged

AJ-1234: Add WsmPactTest #372

merged 1 commit into from
Nov 2, 2023

Conversation

jladieu
Copy link
Contributor

@jladieu jladieu commented Oct 16, 2023

This is the first of several test suites verifying interaction with WSM; this one focuses specifically on createDataRepoSnapshotReference.

Is paired with DataBiosphere/terra-workspace-manager#1511

@jladieu jladieu force-pushed the AJ-1234-wsm-consumer-pact-tests branch 5 times, most recently from 35f8c49 to 986d298 Compare October 25, 2023 19:18
@jladieu jladieu changed the base branch from main to rename-sam-consumer-provider October 25, 2023 19:19
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 25, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 25, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 25, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
@jladieu jladieu force-pushed the rename-sam-consumer-provider branch 2 times, most recently from 77c6712 to 7393b8d Compare October 30, 2023 15:30
Base automatically changed from rename-sam-consumer-provider to main October 30, 2023 19:11
@jladieu jladieu force-pushed the AJ-1234-wsm-consumer-pact-tests branch 2 times, most recently from 85c83c2 to 04b7cf9 Compare October 30, 2023 19:17
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 30, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 30, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 30, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 31, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 31, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 31, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Oct 31, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
@jladieu jladieu force-pushed the AJ-1234-wsm-consumer-pact-tests branch from 04b7cf9 to 194f5d1 Compare October 31, 2023 18:01
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Nov 1, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Nov 1, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
@jladieu jladieu force-pushed the AJ-1234-wsm-consumer-pact-tests branch 2 times, most recently from f6c678b to 22e0219 Compare November 1, 2023 17:57
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Nov 1, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
newJsonBody(
body ->
body.stringMatcher(
"message", "^(.*)policy conflict(.*)$", "unexpected policy conflict"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailmarker comment for crosslinking from @calypsomatic 's other PR.

@jladieu jladieu force-pushed the AJ-1234-wsm-consumer-pact-tests branch from 03ac19e to cbb0621 Compare November 2, 2023 18:42
@jladieu jladieu requested review from calypsomatic and a team November 2, 2023 18:44
Copy link
Contributor

@calypsomatic calypsomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the code organization! So neat and clean!

This is the first of several test suites verifying interaction with WSM;
this one focuses specifically on `createDataRepoSnapshotReference`.
@jladieu jladieu force-pushed the AJ-1234-wsm-consumer-pact-tests branch from cbb0621 to 2fa1341 Compare November 2, 2023 20:02
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jladieu jladieu merged commit f142337 into main Nov 2, 2023
13 checks passed
@jladieu jladieu deleted the AJ-1234-wsm-consumer-pact-tests branch November 2, 2023 20:10
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Nov 3, 2023
This pairs with
DataBiosphere/terra-workspace-data-service#372
to establish a contract between WDS and WSM, initially focused on
`ReferencedGcpResourceController`.
jladieu added a commit to DataBiosphere/terra-workspace-manager that referenced this pull request Nov 7, 2023
This pairs with DataBiosphere/terra-workspace-data-service#372 to establish a contract between WDS and WSM, initially focused on `ReferencedGcpResourceController`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants