Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup stairway serialization tests and fix a few other warnings #199

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Cleanup stairway serialization tests and fix a few other warnings #199

wants to merge 4 commits into from

Conversation

pshapiro4broad
Copy link
Member

@pshapiro4broad pshapiro4broad commented Sep 9, 2024 •
edited
Loading

A few test related cleanups

  • remove pmd / quality plugin as its functionality is subsumed by the sonar scan
  • fix sonar warnings about calling unnecessary functions inside an assertThrows()
  • refactor common code that tests Stairway serialization for tcl objects and use stairway's ObjectMapper instead of a duplicate
  • replace casts with generics, or use type parameter to avoid casting
  • in modified files, replace wildcard imports with explicit imports, remove unnecessary public

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pshapiro4broad