Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation query and testOnBorrow to ensure we do not attempt to use invalid connections #486

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add validation query and testOnBorrow to ensure we do not attempt to use invalid connections #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions service/src/main/java/bio/terra/profile/app/configuration/BaseDatabaseConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import org.apache.commons.dbcp2.PoolingDataSource;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;
import org.apache.commons.pool2.ObjectPool;
import org.apache.commons.pool2.impl.GenericObjectPool;

/** Base class for accessing database connection configuration properties. */
Expand Down Expand Up @@ -64,10 +63,11 @@ private void configureDataSource() {

PoolableConnectionFactory poolableConnectionFactory =
new PoolableConnectionFactory(connectionFactory, null);
poolableConnectionFactory.setValidationQuery("SELECT 1");

ObjectPool<PoolableConnection> connectionPool =
GenericObjectPool<PoolableConnection> connectionPool =
new GenericObjectPool<>(poolableConnectionFactory);

connectionPool.setTestOnBorrow(true);
poolableConnectionFactory.setPool(connectionPool);

dataSource = new PoolingDataSource<>(connectionPool);
Expand Down
Loading